Skip to content

Turbopack: add more side effects test cases #82465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 8, 2025
Merged

Turbopack: add more side effects test cases #82465

merged 5 commits into from
Aug 8, 2025
+92 −0

Conversation

sokra
Copy link
Member

@sokra sokra commented Aug 8, 2025 •
edited by padmaia
Loading

What?

Add more test cases for the side effects optimization that are currently broken

Closes #82411

Closes PACK-5201

@ijjk ijjk added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Aug 8, 2025
@sokra sokra mentioned this pull request Aug 8, 2025
Merged
@sokra Graphite App
Copy link
Member Author

sokra commented Aug 8, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Aug 8, 2025
Merged
Merged
Draft
@sokra sokra changed the title add test case Turbopack: add test case Aug 8, 2025
@sokra sokra changed the title Turbopack: add test case Turbopack: add more side effects test cases Aug 8, 2025
@sokra sokra marked this pull request as ready for review August 8, 2025 08:58
@sokra sokra requested a review from mischnic August 8, 2025 08:58
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 8, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #82465 will not alter performance

Comparing sokra/add-side-effects-test-case (8149991) with canary (5869543)1

Summary

✅ 9 untouched benchmarks

Footnotes

  1. No successful run was found on canary (7f1ad3a) during the generation of this report, so 5869543 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@sokra Graphite App
Copy link
Member Author

sokra commented Aug 8, 2025 •
edited
Loading

Merge activity

@austinderek austinderek mentioned this pull request Aug 8, 2025
Closed
@sokra sokra changed the base branch from sokra/split-side-effects-tests to graphite-base/82465 August 8, 2025 09:37
@sokra sokra force-pushed the sokra/add-side-effects-test-case branch from 8a98aab to e96fb3d Compare August 8, 2025 11:17
@sokra sokra force-pushed the graphite-base/82465 branch from 1a2089f to 7f1ad3a Compare August 8, 2025 11:17
@graphite-app graphite-app bot changed the base branch from graphite-base/82465 to canary August 8, 2025 11:18
@sokra sokra force-pushed the sokra/add-side-effects-test-case branch from e96fb3d to 8149991 Compare August 8, 2025 11:18
@sokra sokra merged commit 8f8c78e into canary Aug 8, 2025
175 of 176 checks passed
@sokra sokra deleted the sokra/add-side-effects-test-case branch August 8, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@mischnic mischnic mischnic approved these changes

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sokra @mischnic @ijjk