Skip to content

chore: Remove unused Map support from next/dynamic transform #82487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: bgw/babel-types-and-loader-cleanup
Choose a base branch
from

Conversation

bgw
Copy link
Member

@bgw bgw commented Aug 9, 2025

Noticed while skimming over this code.

It looks like react-loadable had a separate Loadable.Map API (https://github.com/jamiebuilds/react-loadable/tree/master?tab=readme-ov-file#loading-multiple-resources), but next/dynamic doesn't, so we shouldn't check for this.

Copy link
Member Author

bgw commented Aug 9, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@bgw bgw force-pushed the bgw/babel-types-and-loader-cleanup branch from a49fc30 to 4282980 Compare August 9, 2025 00:21
@bgw bgw force-pushed the bgw/rm-next-dynamic-transform-map branch from f7103ca to 0691f97 Compare August 9, 2025 00:21
@bgw bgw marked this pull request as ready for review August 9, 2025 00:21
@bgw bgw requested review from huozhi and timneutkens August 9, 2025 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants