Skip to content

Add tarfile patch for invalid block sizes (SYN-9483) #4428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 30, 2025
Merged

Add tarfile patch for invalid block sizes (SYN-9483) #4428

merged 5 commits into from
Jul 30, 2025

Conversation

vEpiphyte
Copy link
Contributor

No description provided.

@vEpiphyte vEpiphyte added the DO-NOT-MERGE Do not merge this PR yet. label Jul 29, 2025
@vEpiphyte
Copy link
Contributor Author

vEpiphyte commented Jul 29, 2025 •
edited
Loading

Want to make sure the following PRs are also merged ( which would confirm the next micro releases ) before merging this PR:

python/cpython#137172
python/cpython#137171

@codecov Codecov
Copy link

codecov bot commented Jul 29, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.32%. Comparing base (8ea86fc) to head (adfc5de).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
synapse/common.py 80.00% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (80.00%) is below the target coverage (96.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4428      +/-   ##
==========================================
- Coverage   97.39%   97.32%   -0.08%     
==========================================
  Files         269      269              
  Lines       60798    60813      +15     
==========================================
- Hits        59216    59184      -32     
- Misses       1582     1629      +47
Flag Coverage Δ
linux 97.32% <80.00%> (-0.01%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

MichaelSquires
MichaelSquires previously approved these changes Jul 29, 2025
View reviewed changes
@vEpiphyte vEpiphyte requested a review from MichaelSquires July 29, 2025 17:25
MichaelSquires
MichaelSquires previously approved these changes Jul 29, 2025
View reviewed changes
Cisphyx
Cisphyx reviewed Jul 30, 2025
View reviewed changes
@vEpiphyte @Cisphyx
Update changes/7a21e9faa1da281817fa80a461644231.yaml
adfc5de 
Co-authored-by: Cisphyx <cisphyx@vertex.link>
@vEpiphyte vEpiphyte removed the DO-NOT-MERGE Do not merge this PR yet. label Jul 30, 2025
@vEpiphyte vEpiphyte added this to the v2.218.0 milestone Jul 30, 2025
@vEpiphyte vEpiphyte marked this pull request as ready for review July 30, 2025 14:59
@vEpiphyte vEpiphyte requested a review from MichaelSquires July 30, 2025 19:57
@vEpiphyte vEpiphyte merged commit 4603153 into master Jul 30, 2025
4 of 5 checks passed
@vEpiphyte vEpiphyte deleted the bug_tarfile_patch branch July 30, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cisphyx Cisphyx Cisphyx approved these changes

@MichaelSquires MichaelSquires MichaelSquires approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v2.218.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vEpiphyte @Cisphyx @MichaelSquires