Skip to content

chore: get ci passing and update node #1585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

chore: get ci passing and update node #1585

wants to merge 14 commits into from

Conversation

Essk
Copy link
Contributor

@Essk Essk commented Jul 23, 2025 •
edited
Loading

It seems ci test runs have been failing for a while and after a bit of investigation there seem to be two main culprits:

  1. We need to pin Firefox to v64, same as for VJS
  2. Looks like there may be a regression in playback for the source used for "DRM Dash" playback test. This asset plays in the DASH reference player but not the VHS demo.
  • We recently improved support for multi-DRM in contrib-eme, so I've bumped to the latest version but sadly this doesn't seem to fix things for this asset. Further investigation will be needed.

For good measure, I've also updated Node to v22.

@codecov Codecov
Copy link

codecov bot commented Jul 23, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.00%. Comparing base (bd810ea) to head (d2c6c8a).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1585   +/-   ##
=======================================
  Coverage   84.00%   84.00%           
=======================================
  Files          44       44           
  Lines       11710    11710           
  Branches     2625     2625           
=======================================
  Hits         9837     9837           
  Misses       1873     1873

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Essk Essk changed the title chore: update to node 22 chore: get ci passing and update node Jul 23, 2025
@Essk Essk marked this pull request as ready for review July 23, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Essk