Skip to content

Fix 8141: fix npm run build sass icon failure which prevents types from being built #8217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Fix 8141: fix npm run build sass icon failure which prevents types from being built #8217

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
964421b
Try locally
zorent-zebra Mar 29, 2023
6965546
Fix 8141 and dart-sass errors so angular 15 can get types
zorent-zebra Mar 29, 2023
8232d2c
Bring back types accidentally removed
zorent-zebra Mar 29, 2023
cec7a5b
Merge branch 'videojs:main' into fix-npm-run-build-sass-icons
zorent-zebra Apr 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix 8141 and dart-sass errors so angular 15 can get types
  • Loading branch information
@zorent-zebra
zorent-zebra committed Mar 29, 2023
commit 696554609361ccbf36063815bf19ff185f983a04
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@
"copy:examples": "shx cp -R docs/examples dist/",
"build:js": "rollup -c",
"build:css": "npm-run-all build:css:*",
"build:css:cdn": "sass --load-path='./' --load-path='./node_modules/' --no-source-map src/css/vjs-cdn.scss dist/alt/video-js-cdn.css",
"build:css:cdn": "sass --load-path=./ --load-path=./node_modules/ --no-source-map src/css/vjs-cdn.scss dist/alt/video-js-cdn.css",
"build:types": "tsc",
"postbuild:css:cdn": "postcss --verbose --config postcss.config.js -d dist/alt dist/alt/video-js-cdn.css",
"build:css:default": "sass --load-path='./' --load-path='./node_modules/' --no-source-map src/css/vjs.scss dist/video-js.css",
"build:css:default": "sass --load-path=./ --load-path=./node_modules/ --no-source-map src/css/vjs.scss dist/video-js.css",
"postbuild:css:default": "postcss --verbose --config postcss.config.js -d dist/ dist/video-js.css",
"prebuild:lang": "npm-run-all -s prebuild:lang:*",
"prebuild:lang:chinese-s": "shx cp lang/zh-CN.json lang/zh-Hans.json",
Expand Down