Skip to content

feat: Add mediasession support #8309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

feat: Add mediasession support #8309

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
4467521
feat: Add mediasession support
mister-ben Apr 28, 2023
768ef78
Merge branch 'main' into feat-mediasession
mister-ben Jun 1, 2023
9be74c3
move to separate file
mister-ben Jun 2, 2023
232e021
Merge branch 'main' into feat-mediasession
mister-ben Jun 2, 2023
aa076f4
add type
mister-ben Jun 2, 2023
2b2d856
Merge branch 'main' into feat-mediasession
mister-ben Jun 2, 2023
c9bd625
mock test
mister-ben Jun 2, 2023
b9c3aa6
guard against non finite duration
mister-ben Jun 2, 2023
b67a9ee
more tests
mister-ben Jun 3, 2023
2a10d09
always need to wait for playlist
mister-ben Jun 3, 2023
8a659d2
more tests
mister-ben Jun 3, 2023
16bf589
repush
mister-ben Jun 3, 2023
d892c16
lint
mister-ben Jun 3, 2023
5314f5d
lint
mister-ben Jun 4, 2023
6332b13
more test coverage
mister-ben Jun 4, 2023
662989b
test handlers to incresase coverage
mister-ben Jun 9, 2023
4136a53
Merge branch 'main' into feat-mediasession
mister-ben Jun 9, 2023
43536f0
fix playlist handler test
mister-ben Jun 9, 2023
e6c541c
Merge branch 'main' into feat-mediasession
mister-ben Dec 4, 2023
b249c67
Apply suggestions from code review
mister-ben Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
mock test
  • Loading branch information
@mister-ben
mister-ben committed Jun 2, 2023
commit c9bd62520e2388bbb308350e64d160d88eff4548
39 changes: 34 additions & 5 deletions test/unit/player-mediasession.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,43 @@ import sinon from 'sinon';
import window from 'global/window';

QUnit.module('Player: MediaSession', {
before() {
if (!('mediaSession' in window.navigator)) {
window.navigator.mediaSession = {
setPositionState: () => {},
setHandlerAction: () => {},
metadata: {},
_mocked: true
};

// Object.defineProperty(window.navigator, 'mediaSession', {
// configurable: true,
// enumerable: true,
// value: mockMediaSession,
// writable: true
// });

window.navigator.MediaMetadata = class MediaMetadata {
constructor(data) {
return data;
}
};
}
},
afterEach() {
this.player.dispose();
},
after() {
if (window.navigator.mediaSession._mocked) {
delete window.navigator.mediaSession;
delete window.navigator.MediaMetadata;
}
}
});

const testOrSkip = 'mediasession' in window.navigator ? 'test' : 'skip';
// const testOrSkip = 'mediasession' in window.navigator ? 'test' : 'skip';

QUnit[testOrSkip]('mediasession data is populated from getMedia', function(assert) {
QUnit.test('mediasession data is populated from getMedia', function(assert) {
const done = assert.async();

this.player = TestHelpers.makePlayer({
Expand Down Expand Up @@ -45,7 +74,7 @@ QUnit[testOrSkip]('mediasession data is populated from getMedia', function(asser
this.player.trigger('playing');
});

QUnit[testOrSkip]('mediasession data is populated from playlist', function(assert) {
QUnit.test('mediasession data is populated from playlist', function(assert) {
const done = assert.async();

this.player = TestHelpers.makePlayer({
Expand Down Expand Up @@ -83,7 +112,7 @@ QUnit[testOrSkip]('mediasession data is populated from playlist', function(asser
this.player.trigger('playing');
});

QUnit[testOrSkip]('mediasession data set', function(assert) {
QUnit.test('mediasession data set', function(assert) {
this.clock = sinon.useFakeTimers();
this.player = TestHelpers.makePlayer({
mediaSession: true
Expand All @@ -110,7 +139,7 @@ QUnit[testOrSkip]('mediasession data set', function(assert) {
this.clock.restore();
});

QUnit[testOrSkip]('mediasession can be customised befire being set', function(assert) {
QUnit.test('mediasession can be customised befire being set', function(assert) {
assert.expect(3);

this.clock = sinon.useFakeTimers();
Expand Down