fix(scanner): skip svelte components with #snippet
#20562
+59
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20511
When a Svelte file exports snippets through its
<script module>
block, Vite's dependency scanner fails with an esbuild error:This happens because snippets are defined in the template using
{#snippet foo()}
syntax, but the scanner only sees the script block whereexport { foo }
references an undeclared identifier.Solution
This PR adds special handling for Svelte files containing
#snippet
:<script module>
blocks, check if the file content contains#snippet
export * from 'svelte-snippet-dummy:filename'
to handle snippet exports that aren't defined in the script blocksvelte-snippet-dummy
Example
Before this fix, this Svelte file would cause scanning to fail:
After the fix, the scanner generates:
The virtual module is externalized, preventing esbuild from trying to resolve snippet exports that don't exist in the script block.
Testing
This change is backward compatible and only affects Svelte files that contain
#snippet
syntax.💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.