refactor: merge the parser config

posva · posva · commit 08dfd9e2bbe2 · 2025-08-08T23:25:35.000+02:00
diff --git a/packages/experiments-playground/src/router/index.ts b/packages/experiments-playground/src/router/index.ts
@@ -144,9 +144,7 @@ const r_profiles_detail = normalizeRouteRecord({
   path: new MatcherPatternPathCustomParams(
     /^\/profiles\/([^/]+)$/i,
     {
-      userId: {
-        parser: PARAM_INTEGER,
-      },
+      userId: PARAM_INTEGER,
     },
     ['profiles', 0]
   ),
diff --git a/packages/router/src/experimental/route-resolver/matchers/matcher-pattern.spec.ts b/packages/router/src/experimental/route-resolver/matchers/matcher-pattern.spec.ts
@@ -141,7 +141,7 @@ describe('MatcherPatternPathCustom', () => {
     const pattern = new MatcherPatternPathCustomParams(
       /^\/teams(?:\/([^/]+?))?\/b$/i,
       {
-        teamId: { optional: true },
+        teamId: {},
       },
       ['teams', 0, 'b']
     )
@@ -177,7 +177,7 @@ describe('MatcherPatternPathCustom', () => {
     const pattern = new MatcherPatternPathCustomParams(
       /^\/teams(?:\/(.+?))?\/b$/i,
       {
-        teamId: { repeat: true, optional: true },
+        teamId: { repeat: true },
       },
       ['teams', 0, 'b']
     )
diff --git a/packages/router/src/experimental/route-resolver/matchers/matcher-pattern.ts b/packages/router/src/experimental/route-resolver/matchers/matcher-pattern.ts
@@ -198,11 +198,11 @@ export type ParamsFromParsers<P extends Record<string, ParamParser_Generic>> = {
 interface MatcherPatternPathCustomParamOptions<
   TIn extends string | string[] | null = string | string[] | null,
   TOut = string | string[] | null,
-> {
+> extends Param_GetSet<TIn, TOut> {
   repeat?: boolean
-  // TODO: not needed because in the regexp, the value is undefined if the group is optional and not given
-  optional?: boolean
-  parser?: Param_GetSet<TIn, TOut>
+  // NOTE: not needed because in the regexp, the value is undefined if
+  // the group is optional and not given
+  // optional?: boolean
 }
 
 /**
@@ -295,7 +295,7 @@ export class MatcherPatternPathCustomParams<
           )
         : decode(currentMatch)
 
-      params[paramName] = (paramOptions.parser?.get || (v => v))(
+      params[paramName] = (paramOptions.get || (v => v))(
         value
         // NOTE: paramName and paramOptions are not connected from TS point of view
       )
@@ -325,7 +325,7 @@ export class MatcherPatternPathCustomParams<
           const paramName = this.paramsKeys[paramIndex++]
           const paramOptions = this.params[paramName]
           const value: ReturnType<NonNullable<Param_GetSet['set']>> = (
-            paramOptions.parser?.set || (v => v)
+            paramOptions.set || (v => v)
           )(params[paramName])
 
           return Array.isArray(value)

Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@ describe('MatcherPatternPathCustom', () => {`
`141`	`141`	`const pattern = new MatcherPatternPathCustomParams(`
`142`	`142`	`/^\/teams(?:\/([^/]+?))?\/b$/i,`
`143`	`143`	`{`
`144`		`- teamId: { optional: true },`
	`144`	`+ teamId: {},`
`145`	`145`	`},`
`146`	`146`	`['teams', 0, 'b']`
`147`	`147`	`)`
`@@ -177,7 +177,7 @@ describe('MatcherPatternPathCustom', () => {`
`177`	`177`	`const pattern = new MatcherPatternPathCustomParams(`
`178`	`178`	`/^\/teams(?:\/(.+?))?\/b$/i,`
`179`	`179`	`{`
`180`		`- teamId: { repeat: true, optional: true },`
	`180`	`+ teamId: { repeat: true },`
`181`	`181`	`},`
`182`	`182`	`['teams', 0, 'b']`
`183`	`183`	`)`