Fix TypeScript type issues in experimental router by removing @ts-expect-error suppressions #2543
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses TypeScript type mismatches in the experimental router by removing all
@ts-expect-error
comments and implementing proper type bridges between experimental resolver types and standard Vue Router types.Problem
The experimental router had 17
@ts-expect-error
comments indicating unresolved type incompatibilities, primarily around:resolver.resolve()
method calls with incompatible parameter typesmatched
property differences betweenResolverLocationResolved
andRouteLocationResolved
Solution
Core Type Bridge
Added proper type conversion between the experimental resolver system and standard Vue Router types:
Enhanced Type Definitions
Broadened
_resolveArgs
type union to handle all input variants:Fixed Return Type Conversion
Replaced problematic
assign()
usage with proper object spreading forRouteLocationResolved
compatibility:Impact
@ts-expect-error
comments removedThe experimental router now has clean, type-safe code without any TypeScript suppressions, making it more maintainable and less error-prone for future development.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
googlechromelabs.github.io
node install.js
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.