Skip to content

feat(useAsyncState)!: set globalThis.reportError as default onError #4951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kalu5
Copy link
Contributor

@kalu5 kalu5 commented Aug 9, 2025

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

Additional context

In useAsyncState, awaited errors are silently ignored by default since onError has value noop. It should probably instead use either globalThis.reportError

Reproduction

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Aug 9, 2025
Copy link

pkg-pr-new bot commented Aug 9, 2025

Open in StackBlitz

@vueuse/components

npm i https://pkg.pr.new/@vueuse/components@4951

@vueuse/core

npm i https://pkg.pr.new/@vueuse/core@4951

@vueuse/electron

npm i https://pkg.pr.new/@vueuse/electron@4951

@vueuse/firebase

npm i https://pkg.pr.new/@vueuse/firebase@4951

@vueuse/integrations

npm i https://pkg.pr.new/@vueuse/integrations@4951

@vueuse/math

npm i https://pkg.pr.new/@vueuse/math@4951

@vueuse/metadata

npm i https://pkg.pr.new/@vueuse/metadata@4951

@vueuse/nuxt

npm i https://pkg.pr.new/@vueuse/nuxt@4951

@vueuse/router

npm i https://pkg.pr.new/@vueuse/router@4951

@vueuse/rxjs

npm i https://pkg.pr.new/@vueuse/rxjs@4951

@vueuse/shared

npm i https://pkg.pr.new/@vueuse/shared@4951

commit: f44bbe1

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 9, 2025
@Alfred-Skyblue Alfred-Skyblue changed the title feat(useAsyncState): set globalThis.reportError as default onError feat(useAsyncState)!: set globalThis.reportError as default onError Aug 11, 2025
@OrbisK
Copy link
Collaborator

OrbisK commented Aug 11, 2025

@antfu If we consider this a breaking change, then #4943 was one too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants