Skip to content

feat(webdriverio): improved element array implementation #14285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat(webdriverio): improved element array implementation #14285

wants to merge 7 commits into from

Conversation

christian-bromann
Copy link
Member

@christian-bromann christian-bromann commented Mar 14, 2025 •
edited
Loading

Proposed changes

Our current implementation of an element array wasn't very clean and needs improvement. While thinks like:

const elem = $$('div').find((el) => (await el.getTagName()) === 'div')

worked, it was not possible to do things like:

for await(const el of $$('div')) {
  // ...
}

This patch improves the implementation and moves the logic from the shim into a new class for handling the entire element array. The goal here is to make handling element lists very easy and as native as possible.

fixes #14450

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: New Feature 🚀 PRs that contain new features label Mar 14, 2025
@christian-bromann christian-bromann mentioned this pull request May 4, 2025
Closed
1 task
@christian-bromann christian-bromann force-pushed the cb/element-array-rewrite branch from 72703d6 to 1c1232f Compare May 12, 2025 01:47
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 12, 2025 •
edited
Loading

Open in StackBlitz

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14285

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14285

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14285

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14285

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14285

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14285

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14285

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14285

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14285

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14285

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14285

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14285

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14285

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14285

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14285

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14285

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14285

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14285

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14285

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14285

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14285

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14285

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14285

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14285

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14285

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14285

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14285

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14285

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14285

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14285

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14285

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14285

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14285

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14285

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14285

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14285

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14285

commit: b8b7374

@christian-bromann christian-bromann marked this pull request as ready for review May 12, 2025 02:46
@christian-bromann christian-bromann force-pushed the cb/element-array-rewrite branch from 849e5da to b8b7374 Compare May 25, 2025 20:16
@christian-bromann christian-bromann mentioned this pull request Jul 25, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: New Feature 🚀 PRs that contain new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[💡 Feature]: Improving ChainablePromiseArray and ChainablePromiseElement
1 participant
@christian-bromann