fix: tree-shakable module library should align with the allowInlineStartup condition
#19714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #19714 will improve performances by 36.21%Comparing Summary
Benchmarks breakdown
|
|
@hai-x Still WIP? |
7ad493d to
f7e6087
Compare
|
@hai-x Can you rebase? |
|
lgtm |
|
@hai-x Looks like some tests are failed due snapshots, let's rebase and include these changes in the next release, thank you for your work |
alexander-akait
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes #18272 (comment).
When the ESM entry module is guaranteed to be inlined without being wrapped in an IIFE, we generate export statements at the top level to enhance tree-shaking. Otherwise, we place them within the module factory.
Therefore, we must verify the prerequisites for
allowInlineStartupandiifeto ensure correct behavior.Did you add tests for your changes?
Yes. Feel free to more requirement.
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
No