Skip to content

refactor: optimize connection lookup and add generic grouping #19760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2025

Conversation

xiaoxiaojx
Copy link
Member

What kind of change does this PR introduce?
refactor: optimize connection lookup and add generic grouping

Did you add tests for your changes?
No

Does this PR introduce a breaking change?
No

What needs to be documented once your changes are merged?
No

Copy link

codspeed-hq bot commented Aug 3, 2025

CodSpeed Performance Report

Merging #19760 will degrade performances by 28.34%

Comparing perf/getConnections (6697f54) with main (de79ee4)

Summary

⚡ 6 improvements
❌ 1 regressions
✅ 35 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
benchmark "cache-filesystem", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 232.5 ms 16.1 ms ×14
benchmark "devtool-eval", scenario '{"name":"mode-development","mode":"development"}' 297.6 ms 229.8 ms +29.52%
benchmark "devtool-eval", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 106.3 ms 84.3 ms +26.06%
benchmark "lodash", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 82.6 ms 56 ms +47.57%
benchmark "many-modules-commonjs", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 93.7 ms 130.7 ms -28.34%
benchmark "react", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 89.8 ms 70 ms +28.32%
benchmark "three-long", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 230.1 ms 39.2 ms ×5.9

@alexander-akait alexander-akait merged commit e8e9f15 into main Aug 4, 2025
41 checks passed
@alexander-akait alexander-akait deleted the perf/getConnections branch August 4, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants