Skip to content

fix(esm): fix the failure export of internal function #19768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2025
Merged

fix(esm): fix the failure export of internal function #19768

merged 1 commit into from
Aug 6, 2025
+53 −6

Conversation

xiaoxiaojx
Copy link
Member

What kind of change does this PR introduce?
Fixes #19767 The naming of functions exported within webpack cannot use "default" because the entryModule may have a default export.

Did you add tests for your changes?
Yes

Does this PR introduce a breaking change?
No

What needs to be documented once your changes are merged?
No

@xiaoxiaojx xiaoxiaojx changed the title fix(esm): fix the failure export of internal function [WIP] fix(esm): fix the failure export of internal function Aug 4, 2025
@xiaoxiaojx xiaoxiaojx mentioned this pull request Aug 4, 2025
Closed
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 4, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #19768 will degrade performances by 96.79%

Comparing fix/esm_export (f78fb22) with main (f2228ea)

Summary

❌ 3 regressions
✅ 39 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ benchmark "lodash", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 27.2 ms 846.4 ms -96.79%
❌ benchmark "many-chunks-esm", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 111 ms 401 ms -72.33%
❌ benchmark "react", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 85.8 ms 118.6 ms -27.64%

@xiaoxiaojx xiaoxiaojx force-pushed the fix/esm_export branch 2 times, most recently from 1323f86 to d320334 Compare August 5, 2025 14:07
@xiaoxiaojx xiaoxiaojx changed the title [WIP] fix(esm): fix the failure export of internal function fix(esm): fix the failure export of internal function Aug 5, 2025
@alexander-akait alexander-akait merged commit af76497 into main Aug 6, 2025
80 of 82 checks passed
@alexander-akait alexander-akait deleted the fix/esm_export branch August 6, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code Splitting not export default
2 participants
@xiaoxiaojx @alexander-akait