chore: fix types #19772
Merged
chore: fix types #19772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #19772 will degrade performances by 49.66%Comparing Summary
Benchmarks breakdown
|
3 tasks
colinaaa
added a commit
to lynx-family/lynx-stack
that referenced
this pull request
Aug 7, 2025
Some pnpm-related tweaks: 1. Upgrade to `pnpm@10.14.0`. 2. Fix `webpack@5.99.9` patch failed since we have `ignorePatchFailures: false` (the patch has been merged in webpack/webpack#19772, so we can remove it from next webpack release). 3. ~~Add `typescript` to the `peerDependencies` of `ts-patch` for enableGlobalVirtualStore. This would solve the "Error: Cannot find module 'typescript'" error during local `pnpm install`.~~ We disabled `enableGlobalVirtualStore` for now. ReactLynx needs `preact` and `@lynx-js/react` to be hoisted. 4. Remove useless overrides to `path-serializer`. 5. Remove `@pnpm/plugin-better-defaults` due to pnpm/plugin-better-defaults#2 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Updated the package manager version to pnpm 10.14.0. * Improved workspace configuration for dependency management, including more precise patching and enhanced compatibility for certain packages. <!-- end of auto-generated comment: release notes by coderabbit.ai --> ## Checklist <!--- Check and mark with an "x" --> - [ ] Tests updated (or not required). - [ ] Documentation updated (or not required). - [ ] Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix types
Did you add tests for your changes?
Existing
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
Nothing