Skip to content

refactor: fix types #19777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2025
Merged

refactor: fix types #19777

merged 1 commit into from
Aug 11, 2025

Conversation

alexander-akait
Copy link
Member

What kind of change does this PR introduce?

refactor - fix types to update typescript

Did you add tests for your changes?

No need

Does this PR introduce a breaking change?

No

What needs to be documented once your changes are merged?

Nothing

Copy link

codspeed-hq bot commented Aug 9, 2025

CodSpeed Performance Report

Merging #19777 will degrade performances by 86.92%

Comparing refactor-fix-types (c6cafff) with main (67379fe)

Summary

⚡ 4 improvements
❌ 2 regressions
✅ 36 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
benchmark "cache-filesystem", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 340.7 ms 231.4 ms +47.22%
benchmark "devtool-eval-source-map", scenario '{"name":"mode-development","mode":"development"}' 265.7 ms 363.4 ms -26.89%
benchmark "future-defaults", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 14.7 ms 112.2 ms -86.92%
benchmark "many-chunks-esm", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 104.3 ms 59.2 ms +76.23%
benchmark "many-modules-commonjs", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 121.6 ms 91 ms +33.57%
benchmark "three-long", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 361.6 ms 38.3 ms ×9.4

@alexander-akait alexander-akait merged commit 60e0589 into main Aug 11, 2025
42 of 44 checks passed
@alexander-akait alexander-akait deleted the refactor-fix-types branch August 11, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant