plugins/woocommerce/src/Internal/CLI/Migrator/Runner.php (2)

9-9: Remove unused import

The WC_Product_Factory import is not used in this file and should be removed.

-use WC_Product_Factory;

---

21-51: Consider adding error handling for container resolution

The command registration looks good and follows WooCommerce patterns. However, consider adding error handling in case the container fails to resolve the command classes.

 	public static function register_commands(): void {
 		$container = wc_get_container();
 
+		try {
 			// Products Command
 			WP_CLI::add_command(
 				'wc migrator products',
 				$container->get( ProductsCommand::class ),
 				array(
 					'shortdesc' => 'Migrate products from a source platform to WooCommerce.',
 					'longdesc'  => 'Migrate products from a source platform to WooCommerce. The migrator will fetch products from the source platform, map them to the WooCommerce product schema, and then import them into WooCommerce.',
 				)
 			);
 
 			// Reset Command
 			WP_CLI::add_command(
 				'wc migrator reset',
 				$container->get( ResetCommand::class ),
 				array(
 					'shortdesc' => 'Resets (deletes) the credentials for a given platform.',
 				)
 			);
 
 			// Setup Command
 			WP_CLI::add_command(
 				'wc migrator setup',
 				$container->get( SetupCommand::class ),
 				array(
 					'shortdesc' => 'Interactively sets up the credentials for a given platform.',
 				)
 			);
+		} catch ( Exception $e ) {
+			WP_CLI::error( 'Failed to register migrator commands: ' . $e->getMessage() );
+		}
 	}

plugins/woocommerce/src/Internal/CLI/Migrator/Commands/BaseCommand.php (1)

26-28: Consider adding validation for CredentialManager dependency

The dependency injection should validate that the CredentialManager is properly initialized.

 	final public function init( CredentialManager $credential_manager ): void {
+		if ( ! $credential_manager instanceof CredentialManager ) {
+			WP_CLI::error( 'Invalid CredentialManager instance provided.' );
+		}
+		
 		$this->credential_manager = $credential_manager;
 	}

plugins/woocommerce/src/Internal/CLI/Migrator/Commands/ProductsCommand.php (2)

21-26: Remove unused parameter to clean up the method signature.

The static analysis correctly identifies that the $args parameter is unused. Since this is a WP-CLI command that only uses associative arguments, you can remove it from the signature.

-	 * @param array $args       The positional arguments.
 	 * @param array $assoc_args The associative arguments.
 	 *
 	 * @return void
 	 */
-	public function __invoke( array $args, array $assoc_args ): void {
+	public function __invoke( array $assoc_args ): void {

---

29-34: Consider adding error handling for credential setup failures.

The current implementation assumes that handle_credential_setup() will always succeed, but credential setup could fail for various reasons (network issues, validation errors, etc.).

		if ( ! $this->credential_manager->has_credentials( $platform ) ) {
			WP_CLI::log( "Credentials for '{$platform}' not found. Let's set them up." );
-			$this->handle_credential_setup( $platform );
-			WP_CLI::success( 'Credentials saved successfully. Please run the command again to begin the migration.' );
-			return;
+			try {
+				$this->handle_credential_setup( $platform );
+				WP_CLI::success( 'Credentials saved successfully. Please run the command again to begin the migration.' );
+			} catch ( Exception $e ) {
+				WP_CLI::error( 'Failed to set up credentials: ' . $e->getMessage() );
+			}
+			return;
		}

plugins/woocommerce/src/Internal/CLI/Migrator/Core/CredentialManager.php (1)

1-96: Consider adding credential cleanup and expiration mechanisms.

For production use, consider implementing:

1. Credential expiration/rotation mechanisms
2. Audit logging for credential access
3. Rate limiting for credential operations
4. Secure credential deletion (overwriting memory)

This could be implemented as additional methods:

public function cleanup_expired_credentials(): void {
    // Implementation for cleaning up expired credentials
}

public function audit_credential_access( string $platform_slug, string $action ): void {
    // Log credential access for security monitoring
}

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

Learnt from: jorgeatorres
PR: woocommerce/woocommerce#59675
File: .github/workflows/release-bump-as-requirement.yml:48-65
Timestamp: 2025-07-15T15:39:21.815Z
Learning: In WooCommerce core repository, changelog entries for all PRs live in `plugins/woocommerce/changelog/` directory and are processed during releases, not at the repository root level.

Learnt from: mikejolley
PR: woocommerce/woocommerce#57961
File: plugins/woocommerce/includes/class-wc-session-handler.php:302-333
Timestamp: 2025-06-19T11:58:57.484Z
Learning: In WooCommerce's session handler, the cart merging behavior was revised to always merge guest and user carts when both contain items, rather than having the guest cart take precedence. The migrate_cart_data() method in class-wc-session-handler.php implements this by using array_merge() to combine both carts when neither is empty.

Learnt from: CR
PR: woocommerce/woocommerce#0
File: .cursor/rules/woo-build.mdc:0-0
Timestamp: 2025-06-30T09:27:12.787Z
Learning: The commands to build the WooCommerce plugin must be run in the main repository directory

Learnt from: prettyboymp
PR: woocommerce/woocommerce#59048
File: .github/workflows/cherry-pick-milestoned-prs.yml:60-83
Timestamp: 2025-06-26T12:45:40.709Z
Learning: WooCommerce uses WordPress versioning conventions where minor versions in X.Y.Z format are constrained to 0-9 (Y cannot exceed 9). This means version increment logic should reset minor to 0 and increment major when minor reaches 9, rather than allowing two-digit minor versions like 9.10 or 9.11.

Learnt from: mreishus
PR: woocommerce/woocommerce#58817
File: plugins/woocommerce/includes/wc-product-functions.php:140-140
Timestamp: 2025-06-13T23:52:46.221Z
Learning: In WooCommerce's wc_delete_product_transients function, the context check includes both $is_admin_page (for regular admin screens) and $is_privileged_ajax (for AJAX requests from users with edit_products capability), ensuring that legitimate admin AJAX operations like product imports/exports can still delete transients.

Learnt from: gigitux
PR: woocommerce/woocommerce#58785
File: plugins/woocommerce/client/blocks/package.json:0-0
Timestamp: 2025-06-17T10:25:36.686Z
Learning: Do not suggest using `cross-env` in the WooCommerce repository as it's deprecated/archived and the team is working to remove it from blocks commands to reduce the dependency tree. Instead, inline environment variables like `WP_EXPERIMENTAL_MODULES=true knip` should work fine in supported environments.

Learnt from: CR
PR: woocommerce/woocommerce#0
File: .cursor/rules/woo-phpunit.mdc:0-0
Timestamp: 2025-06-30T09:27:17.200Z
Learning: Applies to plugins/woocommerce/tests/**/*.php : Run WooCommerce PHPUnit tests for specific files or directories using the command: pnpm run test:php:env {relative_path} --verbose, and ensure the command is run in the plugins/woocommerce directory.

Learnt from: CR
PR: woocommerce/woocommerce#0
File: .cursor/rules/woo-build.mdc:0-0
Timestamp: 2025-06-30T09:27:12.787Z
Learning: The commands to build the WooCommerce plugin must be run in the main repository directory

Learnt from: CR
PR: woocommerce/woocommerce#0
File: .cursor/rules/woo-build.mdc:0-0
Timestamp: 2025-06-30T09:27:12.787Z
Learning: The commands to build the WooCommerce plugin must be run in the main repository directory

Learnt from: CR
PR: woocommerce/woocommerce#0
File: .cursor/rules/woo-phpunit.mdc:0-0
Timestamp: 2025-06-30T09:27:17.200Z
Learning: Applies to plugins/woocommerce/tests/**/*.php : Run WooCommerce PHPUnit tests for specific files or directories using the command: pnpm run test:php:env {relative_path} --verbose, and ensure the command is run in the plugins/woocommerce directory.

Learnt from: CR
PR: woocommerce/woocommerce#0
File: .cursor/rules/woo-build.mdc:0-0
Timestamp: 2025-06-30T09:27:12.787Z
Learning: The commands to build the WooCommerce plugin must be run in the main repository directory

Learnt from: CR
PR: woocommerce/woocommerce#0
File: .cursor/rules/woo-build.mdc:0-0
Timestamp: 2025-06-30T09:27:12.787Z
Learning: The commands to build the WooCommerce plugin must be run in the main repository directory