Skip to content

Bump fulfillment hook and template versions to 10.1.0 #59783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 18, 2025
Merged

Bump fulfillment hook and template versions to 10.1.0 #59783

merged 4 commits into from
Jul 18, 2025

Conversation

tpaksu
Copy link
Contributor

@tpaksu tpaksu commented Jul 18, 2025 •
edited
Loading

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR renames hooks added in fulfillments with the wc_fulfillment prefix to have the standard form of woocommerce_fulfillment prefix, and bumps the version number on the @since 9.9.0 tagged filters to 10.1.0.

Closes #59456 WOOPLUG-4911 .

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

The code changes:

  • should only contain wc_fulfillment -> woocommerce_fulfillment and 9.9.0 -> 10.0.1 changes,
  • should make sense,
  • didn't miss one instance, and
  • the automated tests should pass.

Changelog entry

  • Automatically create a changelog entry from the details below.
  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Changelog Entry Comment

Comment

This PR is a part of a feature branch, which will have it's own changelog.

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jul 18, 2025
@tpaksu
Merge branch 'feature/57353-order-fulfillments-entity' into fix/59456…
d8eb81e 
…-order-fulfillments-replace-all-new-since-version-tags-with-101
@tpaksu tpaksu marked this pull request as ready for review July 18, 2025 13:27
@tpaksu tpaksu requested a review from ismaeldcom July 18, 2025 13:27
@github-actions GitHub Actions
Copy link
Contributor

Testing Guidelines

Hi @ismaeldcom ,

Apart from reviewing the code changes, please make sure to review the testing instructions (Guide) and verify that relevant tests (E2E, Unit, Integration, etc.) have been added or updated as needed.

Reminder: PR reviewers are required to document testing performed. This includes:

  • 🖼️ Screenshots or screen recordings.
  • 📝 List of functionality tested / steps followed.
  • 🌐 Site details (environment attributes such as hosting type, plugins, theme, store size, store age, and relevant settings).
  • 🔍 Any analysis performed, such as assessing potential impacts on environment attributes and other plugins, conducting performance profiling, or using LLM/AI-based analysis.

⚠️ Within the testing details you provide, please ensure that no sensitive information (such as API keys, passwords, user data, etc.) is included in this public issue.

ismaeldcom
ismaeldcom approved these changes Jul 18, 2025
View reviewed changes
Copy link
Contributor

@ismaeldcom ismaeldcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although I've found the following unchanged cases, not sure if they also need to be updated:

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

@tpaksu
Copy link
Contributor Author

tpaksu commented Jul 18, 2025

Thanks @ismaeldcom, I've fixed the findings you pointed out, except the last one, which was a function name :)

@tpaksu tpaksu self-assigned this Jul 18, 2025
@tpaksu tpaksu merged commit f614fe1 into feature/57353-order-fulfillments-entity Jul 18, 2025
31 checks passed
@tpaksu tpaksu deleted the fix/59456-order-fulfillments-replace-all-new-since-version-tags-with-101 branch July 18, 2025 14:15
@github-actions GitHub Actions
Copy link
Contributor

⚠️ API Documentation Reminder

Hi @tpaksu! Your PR contains REST API changes. Please consider updating the REST API documentation if your changes affect the public API.

Changed API files:

plugins/woocommerce/src/Internal/Fulfillments/OrderFulfillmentsRestController.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ismaeldcom ismaeldcom ismaeldcom approved these changes

Assignees

@tpaksu tpaksu

Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpaksu @ismaeldcom