Skip to content

Add full recommended requirements to readme.txt #59794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2025

Conversation

prettyboymp
Copy link
Contributor

@prettyboymp prettyboymp commented Jul 18, 2025

Changes proposed in this Pull Request:

This extends the requirements listed in the readme.txt to include recommendations that are currently listed on https://woocommerce.com/document/server-requirements/.

To simplify the release process, we're going to be updating some of the pages currently on woocommece.com to just point to the requirements as listed on WordPress.org. This is the first step which is including the extra recommendation information. This expanded documentation will be the canonical information that shows up https://wordpress.org/plugins/woocommerce/#installation. Other documents will be updated to point to this.

Closes WOOPLUG-4966 / #59560 .

Changelog entry

  • Automatically create a changelog entry from the details below.
  • This Pull Request does not require a changelog entry. (Comment required below)
    Documentation only.
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Changelog Entry Comment

Comment

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jul 18, 2025
@prettyboymp
Copy link
Contributor Author

Waiting to get confirmation of our current minimum DB requirements as there is conflicting information p1752862458935469-slack-C03CPM3UXDJ

@prettyboymp prettyboymp marked this pull request as ready for review July 21, 2025 13:59
@woocommercebot woocommercebot requested review from a team and albarin and removed request for a team July 21, 2025 13:59
@prettyboymp prettyboymp requested review from a team and kalessil and removed request for albarin and a team July 21, 2025 13:59
Copy link
Contributor

Testing Guidelines

Hi @kalessil ,

Apart from reviewing the code changes, please make sure to review the testing instructions (Guide) and verify that relevant tests (E2E, Unit, Integration, etc.) have been added or updated as needed.

Reminder: PR reviewers are required to document testing performed. This includes:

  • 🖼️ Screenshots or screen recordings.
  • 📝 List of functionality tested / steps followed.
  • 🌐 Site details (environment attributes such as hosting type, plugins, theme, store size, store age, and relevant settings).
  • 🔍 Any analysis performed, such as assessing potential impacts on environment attributes and other plugins, conducting performance profiling, or using LLM/AI-based analysis.

⚠️ Within the testing details you provide, please ensure that no sensitive information (such as API keys, passwords, user data, etc.) is included in this public issue.

Copy link
Contributor

coderabbitai bot commented Jul 21, 2025

📝 Walkthrough

Walkthrough

The minimum requirements section in the WooCommerce readme file was updated to reflect a lower MySQL version requirement, a new minimum WordPress version, and recommendations for memory limit and HTTPS support. A reference to a detailed server requirements link was removed.

Changes

File Change Summary
plugins/woocommerce/readme.txt Updated minimum MySQL version, added minimum WordPress version, added recommendations, removed server requirements link

Estimated code review effort

1 (<30 minutes)


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
plugins/woocommerce/readme.txt (1)

145-149: Minor consistency nit – end punctuation.

In the bullet list, only the last two bullets end with a period. Either finish all bullets with a period or remove them from the last two for stylistic consistency.

📜 Review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b7405c9 and f9f9745.

📒 Files selected for processing (1)
  • plugins/woocommerce/readme.txt (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: jorgeatorres
PR: woocommerce/woocommerce#59675
File: .github/workflows/release-bump-as-requirement.yml:48-65
Timestamp: 2025-07-15T15:39:21.856Z
Learning: In WooCommerce core repository, changelog entries for all PRs live in `plugins/woocommerce/changelog/` directory and are processed during releases, not at the repository root level.
Learnt from: CR
PR: woocommerce/woocommerce#0
File: .cursor/rules/generate-pr-description.mdc:0-0
Timestamp: 2025-07-21T05:22:46.417Z
Learning: Provide clear, step-by-step instructions for how to test the changes in the PR description.
Learnt from: CR
PR: woocommerce/woocommerce#0
File: .cursor/rules/generate-pr-description.mdc:0-0
Timestamp: 2025-07-21T05:22:46.417Z
Learning: Applies to .github/PULL_REQUEST_TEMPLATE.md : Preserve required markdown sections in the PR description, especially those used by automation (e.g., changelog entry details and comments). Do not remove or alter them.
Learnt from: prettyboymp
PR: woocommerce/woocommerce#59048
File: .github/workflows/cherry-pick-milestoned-prs.yml:60-83
Timestamp: 2025-06-26T12:45:40.709Z
Learning: WooCommerce uses WordPress versioning conventions where minor versions in X.Y.Z format are constrained to 0-9 (Y cannot exceed 9). This means version increment logic should reset minor to 0 and increment major when minor reaches 9, rather than allowing two-digit minor versions like 9.10 or 9.11.
Learnt from: vladolaru
PR: woocommerce/woocommerce#59486
File: plugins/woocommerce/src/Internal/Admin/Settings/PaymentsProviders/WooPayments/WooPaymentsService.php:1544-1544
Timestamp: 2025-07-08T11:18:07.871Z
Learning: WooCommerce has polyfills for newer PHP functions (like str_starts_with() from PHP 8.0+), so these functions can be safely used even though WooCommerce supports PHP 7.4+. No need to suggest PHP 7.4 compatible alternatives when polyfills are available.
Learnt from: opr
PR: woocommerce/woocommerce#0
File: :0-0
Timestamp: 2025-06-20T17:38:16.565Z
Learning: WooCommerce legacy JavaScript files in plugins/woocommerce/client/legacy/js/ must use older JavaScript syntax and cannot use modern features like optional chaining (?.) due to browser compatibility requirements. Explicit null checking with && operators should be used instead.
plugins/woocommerce/readme.txt (3)

Learnt from: vladolaru
PR: #59486
File: plugins/woocommerce/src/Internal/Admin/Settings/PaymentsProviders/WooPayments/WooPaymentsService.php:1544-1544
Timestamp: 2025-07-08T11:18:07.871Z
Learning: WooCommerce has polyfills for newer PHP functions (like str_starts_with() from PHP 8.0+), so these functions can be safely used even though WooCommerce supports PHP 7.4+. No need to suggest PHP 7.4 compatible alternatives when polyfills are available.

Learnt from: prettyboymp
PR: #59048
File: .github/workflows/cherry-pick-milestoned-prs.yml:60-83
Timestamp: 2025-06-26T12:45:40.709Z
Learning: WooCommerce uses WordPress versioning conventions where minor versions in X.Y.Z format are constrained to 0-9 (Y cannot exceed 9). This means version increment logic should reset minor to 0 and increment major when minor reaches 9, rather than allowing two-digit minor versions like 9.10 or 9.11.

Learnt from: opr
PR: woocommerce/woocommerce#0
File: :0-0
Timestamp: 2025-06-20T17:38:16.565Z
Learning: WooCommerce legacy JavaScript files in plugins/woocommerce/client/legacy/js/ must use older JavaScript syntax and cannot use modern features like optional chaining (?.) due to browser compatibility requirements. Explicit null checking with && operators should be used instead.

🔇 Additional comments (2)
plugins/woocommerce/readme.txt (2)

146-146: Re-check the downgraded MySQL minimum (5.5.5).

WooCommerce’s own docs and most hosting providers currently recommend MySQL ≥ 5.6 or ≥ 5.7 for decent performance and full UTF-8/utf8mb4 support. Dropping the floor to 5.5.5 could be misleading and ‑ if adopted by users – surface subtle charset or index-length issues.

Please confirm with Core & Hosting teams before merging, or keep the existing 5.6+ requirement.


147-147: “WordPress 6.7 or greater” seems premature.

6.7 is not yet released; setting it as the minimum blocks installs on all current production sites. Double-check if this was meant to be the recommended version instead, or if the correct floor is 6.4/6.5 (matching today’s core policy).

Copy link
Contributor

@albarin albarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting to get confirmation of our current minimum DB requirements as there is conflicting information p1752862458935469-slack-C03CPM3UXDJ

Changes are looking good, pre-approving pending the confirmation of the DB version.

Copy link
Contributor

@kalessil kalessil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@prettyboymp
Copy link
Contributor Author

Waiting to get confirmation of our current minimum DB requirements as there is conflicting information p1752862458935469-slack-C03CPM3UXDJ

Changes are looking good, pre-approving pending the confirmation of the DB version.

Based on discussions, we want to keep compatibility the same as WP core.

@prettyboymp prettyboymp merged commit 0e996a7 into trunk Jul 22, 2025
26 of 29 checks passed
@prettyboymp prettyboymp deleted the WOOPLUG-4966/add-recommended-requirements-wporg branch July 22, 2025 16:55
@github-actions github-actions bot added this to the 10.2.0 milestone Jul 22, 2025
@prettyboymp prettyboymp modified the milestones: 10.2.0, 10.0.0 Jul 23, 2025
github-actions bot pushed a commit that referenced this pull request Jul 23, 2025
* Add full recommended requirements to readme.txt

* Set MySQL version at 5.5.5+
prettyboymp added a commit that referenced this pull request Jul 23, 2025
…e.txt (#59918)

Add full recommended requirements to readme.txt (#59794)

* Add full recommended requirements to readme.txt

* Set MySQL version at 5.5.5+

Co-authored-by: Michael Pretty <prettyboymp@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Jul 23, 2025
* Add full recommended requirements to readme.txt

* Set MySQL version at 5.5.5+
prettyboymp added a commit that referenced this pull request Jul 23, 2025
…e.txt (#59919)

Add full recommended requirements to readme.txt (#59794)

* Add full recommended requirements to readme.txt

* Set MySQL version at 5.5.5+

Co-authored-by: Michael Pretty <prettyboymp@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants