-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Add "Filter" suffix to all product filter block titles and variations #59831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Filter" suffix to all product filter block titles and variations #59831
Conversation
Updates block titles from generic names (Active, Attribute, Price, etc.) to more descriptive "Filter" suffixed names (Active Filters, Attribute Filter, Price Filter, etc.) for better clarity in the block inserter and editor interface.
Testing GuidelinesHi @Aljullu , Apart from reviewing the code changes, please make sure to review the testing instructions (Guide) and verify that relevant tests (E2E, Unit, Integration, etc.) have been added or updated as needed. Reminder: PR reviewers are required to document testing performed. This includes:
|
📝 WalkthroughWalkthroughThe changes update the naming conventions of WooCommerce product filter blocks by appending the suffix "Filter" to all relevant block titles and their variations. This includes modifications to block metadata JSON files and the logic generating variation titles, ensuring consistency and improved clarity in block naming and internationalization support. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Editor
participant WooCommerceBlock
User->>Editor: Add/modify product filter block
Editor->>WooCommerceBlock: Render block UI
WooCommerceBlock->>WooCommerceBlock: Display block title (e.g., "Attribute Filter")
WooCommerceBlock->>WooCommerceBlock: For variations, generate title as "%s Filter" (localized)
WooCommerceBlock->>User: Show updated block/variation titles in UI
Estimated code review effort2 (10–30 minutes) 📜 Recent review detailsConfiguration used: .coderabbit.yml 📒 Files selected for processing (7)
🧰 Additional context used📓 Path-based instructions (2)**/*.{php,js,jsx,ts,tsx}📄 CodeRabbit Inference Engine (.cursor/rules/code-quality.mdc)
Files:
**/*.{php,js,ts,jsx,tsx}⚙️ CodeRabbit Configuration File
Files:
🧠 Learnings (8)📓 Common learnings
plugins/woocommerce/changelog/wooplug-4921-add-filter-suffix-to-all-filter-blocks-and-variations-name (2)Learnt from: samueljseay Learnt from: CR plugins/woocommerce/client/blocks/assets/js/blocks/product-filters/inner-blocks/price-filter/block.json (4)Learnt from: ralucaStan Learnt from: samueljseay Learnt from: samueljseay Learnt from: Aljullu plugins/woocommerce/client/blocks/assets/js/blocks/product-filters/inner-blocks/status-filter/block.json (4)Learnt from: ralucaStan Learnt from: Aljullu Learnt from: samueljseay Learnt from: gigitux plugins/woocommerce/client/blocks/assets/js/blocks/product-filters/inner-blocks/active-filters/block.json (6)Learnt from: ralucaStan Learnt from: Aljullu Learnt from: samueljseay Learnt from: samueljseay Learnt from: CR Learnt from: samueljseay plugins/woocommerce/client/blocks/assets/js/blocks/product-filters/inner-blocks/attribute-filter/block.json (4)Learnt from: Aljullu Learnt from: ralucaStan Learnt from: samueljseay Learnt from: samueljseay plugins/woocommerce/client/blocks/assets/js/blocks/product-filters/inner-blocks/attribute-filter/index.tsx (2)Learnt from: samueljseay Learnt from: ralucaStan plugins/woocommerce/client/blocks/assets/js/blocks/product-filters/inner-blocks/rating-filter/block.json (2)Learnt from: samueljseay Learnt from: ralucaStan 🔇 Additional comments (7)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Size Change: +33 B (0%) Total Size: 5.88 MB |
Test using WordPress PlaygroundThe changes in this pull request can be previewed and tested using a WordPress Playground instance. Test this pull request with WordPress Playground. Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Submission Review Guidelines
Changes proposed in this Pull Request
This PR adds a "Filter" suffix to all product filter block titles, making them more descriptive and immediately recognizable as filter-related blocks.
Changes Made:
Why This Change:
The previous generic titles were not descriptive enough in the block inserter interface. Users had to rely on descriptions to understand these were filter-related blocks. The new naming convention provides immediate clarity about the block's purpose.
Closes WOOPLUG-4921.
Closes #59474.
Screenshots or screen recordings
How to test the changes in this Pull Request
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions: