Skip to content

Mini cart block: add margin and padding supports #59872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 6, 2025
Merged

Mini cart block: add margin and padding supports #59872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8bf256f
add spacing supports
MaggieCabrera Jul 22, 2025
a2ef677
undo unrelated change
MaggieCabrera Jul 22, 2025
618e9c6
bring back extra classes
MaggieCabrera Jul 22, 2025
7f9603a
removed var_dump
MaggieCabrera Jul 22, 2025
5b3be09
added changelog
MaggieCabrera Jul 22, 2025
fe9a5be
refactor
MaggieCabrera Jul 22, 2025
4ab0c62
remove empty args
MaggieCabrera Jul 22, 2025
79c890b
removed rebase mistake
MaggieCabrera Aug 6, 2025
3e94575
Merge branch 'trunk' into add-spacing-support-minicart
MaggieCabrera Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions plugins/woocommerce/changelog/add-spacing-support-minicart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: minor
Type: enhancement

Add margin and padding supports to minicart block
4 changes: 4 additions & 0 deletions plugins/woocommerce/client/blocks/assets/js/blocks/mini-cart/block.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@
"multiple": false,
"typography": {
"fontSize": true
},
"spacing": {
"margin": true,
"padding": true
}
},
"example": {
Expand Down
4 changes: 2 additions & 2 deletions plugins/woocommerce/src/Blocks/BlockTypes/MiniCart.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,7 @@ protected function render_experimental_iapi_mini_cart( $attributes, $content, $b
$cart = $this->get_cart_instance();

if ( $cart ) {
$classes_styles = StyleAttributesUtils::get_classes_and_styles_by_attributes( $attributes, array( 'text_color', 'background_color', 'font_size', 'font_weight', 'font_family', 'extra_classes' ) );
$classes_styles = StyleAttributesUtils::get_classes_and_styles_by_attributes( $attributes );
$icon_color = isset( $attributes['iconColor']['color'] ) ? esc_attr( $attributes['iconColor']['color'] ) : 'currentColor';
$product_count_color = isset( $attributes['productCountColor']['color'] ) ? esc_attr( $attributes['productCountColor']['color'] ) : '';
$styles = $product_count_color ? 'background:' . $product_count_color : '';
Expand Down Expand Up @@ -754,7 +754,7 @@ protected function get_markup( $attributes ) {
return '';
}

$classes_styles = StyleAttributesUtils::get_classes_and_styles_by_attributes( $attributes, array( 'text_color', 'background_color', 'font_size', 'font_weight', 'font_family', 'extra_classes' ) );
$classes_styles = StyleAttributesUtils::get_classes_and_styles_by_attributes( $attributes );
$wrapper_classes = sprintf( 'wc-block-mini-cart wp-block-woocommerce-mini-cart %s', $classes_styles['classes'] );
$wrapper_styles = $classes_styles['styles'];

Expand Down
Loading