Skip to content

Load fulfillments classes in init action hook (#59869) #59881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 22, 2025
Merged

Load fulfillments classes in init action hook (#59869) #59881

merged 3 commits into from
Jul 22, 2025

Conversation

tpaksu
Copy link
Contributor

@tpaksu tpaksu commented Jul 22, 2025 •
edited
Loading

Submission Review Guidelines:

Changes proposed in this Pull Request:

Note

The original fix is already merged on trunk: #59869

This PR moves the class initializations of the fulfillments feature to the init action hook, and fixes the tests. (Also fixes one warning surfacing on the test runs, not related with this problem.)

Closes #59870 WOOPLUG-5128

(For Bug Fixes) Bug introduced in PR #57353

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Before this PR, when you go to any page, you'll get a warning on your error log file saying that load text domain was called early. After applying these changes, you should see the warning is gone.

Testing that has already taken place:

Changelog entry

  • Automatically create a changelog entry from the details below.
  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Changelog Entry Comment

Comment

This PR is addressing a CFE by cherry picking a commit from trunk, and it already has a changefile attached.

@tpaksu
Load fulfillments classes in init action hook (#59869)
f62aa3f 
* Load fulfillments classes in init action hook

* Add changefile(s) from automation for the following project(s): woocommerce

* Small change to restart tests

* Remove two consecutive empty lines

---------

Co-authored-by: github-actions <github-actions@github.com>
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jul 22, 2025
@tpaksu tpaksu mentioned this pull request Jul 22, 2025
Closed
9 tasks
@tpaksu tpaksu linked an issue Jul 22, 2025 that may be closed by this pull request
[CFE]: Fix load textdomain just in time warnings caused by fulfillments merge #59882
Closed
9 tasks
@tpaksu tpaksu marked this pull request as ready for review July 22, 2025 11:31
@github-actions GitHub Actions
Copy link
Contributor

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

kalessil
kalessil approved these changes Jul 22, 2025
View reviewed changes
Copy link
Contributor

@kalessil kalessil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Context: p1752849462502169-slack-C07JJG089M0

@github-actions github-actions bot added the cherry pick to trunk Dev only - Part of CFE, PRR flows label Jul 22, 2025
@tpaksu tpaksu self-assigned this Jul 22, 2025
@tpaksu tpaksu merged commit 3533037 into release/10.1 Jul 22, 2025
32 checks passed
@tpaksu tpaksu deleted the fix/fulfillment-classes-causing-load-textdomain-just-in-time-warnings branch July 22, 2025 11:53
@github-actions github-actions bot added the cherry pick failed Used when an automated cherry pick PR (from a CFE or PRR) fails to be generated. label Jul 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

IMPORTANT: Merging this PR to the appropriate branches is critical to the release process and ensures that the bug does not cause regressions in the future releases.

Cherry picking failed for the trunk. Please bring this to release team's attention. Workflow link for debugging: https://github.com/woocommerce/woocommerce/actions/runs/16443499227

@tpaksu
Copy link
Contributor Author

tpaksu commented Jul 22, 2025

Cherry picking failed for the trunk. Please bring this to release team's attention. Workflow link for debugging: https://github.com/woocommerce/woocommerce/actions/runs/16443499227

Cherry picking for the trunk failed because the changes were already merged to trunk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalessil kalessil kalessil approved these changes

Assignees

@tpaksu tpaksu

Labels
cherry pick failed Used when an automated cherry pick PR (from a CFE or PRR) fails to be generated. cherry pick to trunk Dev only - Part of CFE, PRR flows plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CFE]: Fix load textdomain just in time warnings caused by fulfillments merge
2 participants
@tpaksu @kalessil