[Backport to release/10.1] Fix shortcode cart table and update a th to td #59982
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a cherry-pick of #59962 to
release/10.1
.Original PR Description
Submission Review Guidelines:
Changes proposed in this Pull Request:
In PR #57883 we improved the accessibility of the cart table, by introducing scoped headers. One of the
td
inside atbody/tr
was changed to ath
, causing semantic issues.With this PR, we keep the
scope="row"
that was added but change theth
to atd
.Accessibility should function as expected.
This also fixes a visual regression, as reported by @eja2025
Closes #59951
Closes #59887
(For Bug Fixes) Bug introduced in PR #57883 .
Screenshots or screen recordings:
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
dl
should be rendered properlyI'll invite @amberhinds to also test this one, in case it breaks accessibility. Accoding to my research, this should't affect a11y.
Testing that has already taken place:
Changelog entry
Changelog Entry Details
Significance
Type
Message
Changelog Entry Comment
Comment