Amend testing payments documentation link in WooPayments NOX flow #60088

mgascam · 2025-07-29T11:04:18Z

Submission Review Guidelines:

I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have reviewed my code for security best practices.
Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

Closes #WOOPMNT-5218.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Create a new JN store with WooCommerce on this PR's branch (i.e. using Jetpack Beta)
Onboard in WooPayments from WooCommerce Core NOX Flow.
Make the Jetpack connection.
Select Payment Methods.
After adding the payment methods, click on "testing payments on your store."
Check that you are redirected to https://woocommerce.com/document/woopayments/testing-and-troubleshooting/test-accounts/

Testing that has already taken place:

I tested the steps above and the link was pointing to the expected documentation link.

Changelog entry

Automatically create a changelog entry from the details below.

This Pull Request does not require a changelog entry. (Comment required below)

Changelog Entry Details

Significance

Patch
Minor
Major

Type

Fix - Fixes an existing bug
Add - Adds functionality
Update - Update existing functionality
Dev - Development related task
Tweak - A minor adjustment to the codebase
Performance - Address performance issues
Enhancement - Improvement to existing functionality

Message

Changelog Entry Comment

Comment

…edirects-to-sandbox-page-instead

coderabbitai · 2025-07-29T11:55:34Z

📝 Walkthrough

Walkthrough

Documentation links related to WooPayments testing and troubleshooting were updated in multiple components and documentation files to point to the correct "test accounts" page instead of the deprecated sandbox-specific page. No changes were made to logic, control flow, or public interfaces.

Changes

Cohort / File(s)	Change Summary
Changelog Update `plugins/woocommerce/changelog/fix-woopmnt-5218-wc-nox-testing-mode-link-redirects-to-sandbox-page-instead`	Documents the patch fix for the incorrect documentation link in the WooPayments NOX modal.
Modal Link Update `plugins/woocommerce/client/admin/client/settings-payments/components/modals/woo-payments-post-sandbox-account-setup-modal.tsx`	Updates the documentation URL in the modal to point to the "test accounts" page instead of the sandbox page.
Onboarding Step Link Update `plugins/woocommerce/client/admin/client/settings-payments/onboarding/providers/woopayments/steps/test-or-live-account/index.tsx`	Updates the documentation URL in the onboarding step component to point to the "test accounts" page instead of the sandbox page.
Documentation Link Updates `docs/contribution/contributing/common-issues.md`, `docs/contribution/testing/writing-high-quality-testing-instructions.md`	Updates documentation links from the sandbox mode troubleshooting page to the test accounts troubleshooting page.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c8e8a86 and dda3bb5.

📒 Files selected for processing (2)

docs/contribution/contributing/common-issues.md (1 hunks)
docs/contribution/testing/writing-high-quality-testing-instructions.md (1 hunks)

✅ Files skipped from review due to trivial changes (2)

docs/contribution/contributing/common-issues.md
docs/contribution/testing/writing-high-quality-testing-instructions.md

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)

GitHub Check: Metrics - @woocommerce/plugin-woocommerce [performance]
GitHub Check: Core e2e tests 6/6 - @woocommerce/plugin-woocommerce [e2e]
GitHub Check: Core e2e tests 3/6 - @woocommerce/plugin-woocommerce [e2e]
GitHub Check: Core e2e tests 5/6 - @woocommerce/plugin-woocommerce [e2e]
GitHub Check: Core e2e tests 2/6 - @woocommerce/plugin-woocommerce [e2e]
GitHub Check: Core e2e tests 4/6 - @woocommerce/plugin-woocommerce [e2e]
GitHub Check: JavaScript - @woocommerce/admin-library [unit]
GitHub Check: Core e2e tests 1/6 - @woocommerce/plugin-woocommerce [e2e]
GitHub Check: build

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/woopmnt-5218-wc-nox-testing-mode-link-redirects-to-sandbox-page-instead

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

plugins/woocommerce/client/admin/client/settings-payments/components/modals/woo-payments-post-sandbox-account-setup-modal.tsx (1)
113-117: Include noopener in rel for better security when opening a new tab.

Opening external URLs with target="_blank" should add noopener to prevent the new page from accessing window.opener.
- rel="noreferrer"
+ rel="noopener noreferrer"

📜 Review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2781e87 and a93c016.

📒 Files selected for processing (2)

plugins/woocommerce/changelog/fix-woopmnt-5218-wc-nox-testing-mode-link-redirects-to-sandbox-page-instead (1 hunks)
plugins/woocommerce/client/admin/client/settings-payments/components/modals/woo-payments-post-sandbox-account-setup-modal.tsx (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

**/*.{php,js,jsx,ts,tsx}

📄 CodeRabbit Inference Engine (.cursor/rules/code-quality.mdc)

**/*.{php,js,jsx,ts,tsx}: Guard against unexpected inputs
Sanitize and validate any potentially dangerous inputs
Ensure code is backwards compatible
Write code that is readable and intuitive
Ensure code has unit or E2E tests where applicable

Files:

plugins/woocommerce/client/admin/client/settings-payments/components/modals/woo-payments-post-sandbox-account-setup-modal.tsx

**/*.{php,js,ts,jsx,tsx}

⚙️ CodeRabbit Configuration File

**/*.{php,js,ts,jsx,tsx}: Don't trust that extension developers will follow the best practices, make sure the code:

Guards against unexpected inputs.

Sanitizes and validates any potentially dangerous inputs.

Is backwards compatible.

Is readable and intuitive.

Has unit or E2E tests where applicable.

Files:

plugins/woocommerce/client/admin/client/settings-payments/components/modals/woo-payments-post-sandbox-account-setup-modal.tsx

🧠 Learnings (3)

📓 Common learnings

Learnt from: CR
PR: woocommerce/woocommerce#0
File: .cursor/rules/generate-pr-description.mdc:0-0
Timestamp: 2025-07-21T05:22:46.426Z
Learning: Provide clear, step-by-step instructions for how to test the changes in the PR description.

Learnt from: jorgeatorres
PR: woocommerce/woocommerce#59675
File: .github/workflows/release-bump-as-requirement.yml:48-65
Timestamp: 2025-07-15T15:39:21.856Z
Learning: In WooCommerce core repository, changelog entries for all PRs live in `plugins/woocommerce/changelog/` directory and are processed during releases, not at the repository root level.

Learnt from: vladolaru
PR: woocommerce/woocommerce#58784
File: plugins/woocommerce/client/admin/client/settings-payments/onboarding/components/stepper/index.tsx:57-67
Timestamp: 2025-06-20T13:08:44.017Z
Learning: For WooCommerce Payments onboarding step tracking in useEffect hooks, only include the active step in the dependency array, not the context object. The sessionEntryPoint is static throughout the onboarding session and tracking should only fire on actual step navigation, not context changes.

Learnt from: vladolaru
PR: woocommerce/woocommerce#58784
File: plugins/woocommerce/client/admin/client/settings-payments/onboarding/providers/woopayments/steps/business-verification/sections/activate-payments.tsx:33-35
Timestamp: 2025-06-17T10:52:16.648Z
Learning: In WooPayments onboarding flows, vladolaru prefers to handle error tracking on the backend rather than frontend when API calls like disableWooPaymentsTestAccount() fail.

plugins/woocommerce/changelog/fix-woopmnt-5218-wc-nox-testing-mode-link-redirects-to-sandbox-page-instead (3)

Learnt from: jorgeatorres
PR: #59675
File: .github/workflows/release-bump-as-requirement.yml:48-65
Timestamp: 2025-07-15T15:39:21.856Z
Learning: In WooCommerce core repository, changelog entries for all PRs live in plugins/woocommerce/changelog/ directory and are processed during releases, not at the repository root level.

Learnt from: vladolaru
PR: #58784
File: plugins/woocommerce/client/admin/client/settings-payments/onboarding/components/stepper/index.tsx:57-67
Timestamp: 2025-06-20T13:08:44.017Z
Learning: For WooCommerce Payments onboarding step tracking in useEffect hooks, only include the active step in the dependency array, not the context object. The sessionEntryPoint is static throughout the onboarding session and tracking should only fire on actual step navigation, not context changes.

Learnt from: samueljseay
PR: #58716
File: plugins/woocommerce/client/blocks/assets/js/blocks/mini-cart/iapi-frontend.ts:83-101
Timestamp: 2025-06-17T07:07:53.443Z
Learning: In WooCommerce blocks, when porting existing code patterns that have known issues (like parseInt truncating decimal money values), maintain consistency with existing implementation rather than making isolated fixes. The preference is for systematic refactoring approaches (like broader Dinero adoption) over piecemeal changes.

plugins/woocommerce/client/admin/client/settings-payments/components/modals/woo-payments-post-sandbox-account-setup-modal.tsx (8)

Learnt from: vladolaru
PR: #58784
File: plugins/woocommerce/client/admin/client/settings-payments/components/other-payment-gateways/other-payment-gateways.tsx:43-50
Timestamp: 2025-06-18T07:56:06.961Z
Learning: In plugins/woocommerce/client/admin/client/settings-payments/components/other-payment-gateways/other-payment-gateways.tsx, the user vladolaru prefers to keep the current setUpPlugin function signature with optional positional context parameter rather than refactoring to an options object or making context required.

Learnt from: vladolaru
PR: #59160
File: plugins/woocommerce/client/admin/client/settings-payments/onboarding/providers/woopayments/steps/payment-methods-selection/index.tsx:0-0
Timestamp: 2025-06-26T14:56:54.917Z
Learning: In WooCommerce payments onboarding components (like plugins/woocommerce/client/admin/client/settings-payments/onboarding/providers/woopayments/steps/payment-methods-selection/index.tsx), when updating local React state based on API calls, the local state should only be updated after the API call succeeds to prevent inconsistent state if the save operation fails. The pattern is to move setPaymentMethodsState calls inside the .then() callback of the API promise.

Learnt from: vladolaru
PR: #58784
File: plugins/woocommerce/client/admin/client/settings-payments/onboarding/components/stepper/index.tsx:57-67
Timestamp: 2025-06-20T13:08:44.017Z
Learning: For WooCommerce Payments onboarding step tracking in useEffect hooks, only include the active step in the dependency array, not the context object. The sessionEntryPoint is static throughout the onboarding session and tracking should only fire on actual step navigation, not context changes.

Learnt from: dinhtungdu
PR: #59900
File: plugins/woocommerce/client/blocks/assets/js/blocks/product-filters/inner-blocks/attribute-filter/inspector.tsx:0-0
Timestamp: 2025-07-24T05:37:00.907Z
Learning: The DisplayStyleSwitcher component in plugins/woocommerce/client/blocks/assets/js/blocks/product-filters/components/display-style-switcher/index.tsx has been updated so that its onChange prop accepts only a string type (not string | number | undefined), eliminating the need for type assertions when using this component.

Learnt from: ralucaStan
PR: #58782
File: plugins/woocommerce/client/blocks/assets/js/blocks/checkout/inner-blocks/checkout-shipping-address-block/customer-address.tsx:76-90
Timestamp: 2025-06-13T13:37:35.793Z
Learning: In plugins/woocommerce/client/blocks/assets/js/blocks/checkout/inner-blocks/checkout-shipping-address-block/customer-address.tsx, the shouldAnimate flag is expected to be false only on initial render and may remain true after the first edit; it does not need to be reset.

Learnt from: vladolaru
PR: #58784
File: plugins/woocommerce/client/admin/client/settings-payments/onboarding/providers/woopayments/steps/business-verification/sections/activate-payments.tsx:33-35
Timestamp: 2025-06-17T10:52:16.648Z
Learning: In WooPayments onboarding flows, vladolaru prefers to handle error tracking on the backend rather than frontend when API calls like disableWooPaymentsTestAccount() fail.

Learnt from: samueljseay
PR: #59051
File: plugins/woocommerce/client/blocks/assets/js/blocks/mini-cart/mini-cart-contents/inner-blocks/mini-cart-footer-block/index.tsx:66-70
Timestamp: 2025-06-23T05:47:52.696Z
Learning: For WooCommerce mini-cart blocks in plugins/woocommerce/client/blocks/assets/js/blocks/mini-cart/, the standardized conditional pattern for experimental features should be if ( isExperimentalMiniCartEnabled() ) { blockSettings.save = () => <InnerBlocks.Content />; } - defaulting to the traditional Save component and only overriding when the experimental feature is enabled.

Learnt from: Aljullu
PR: #58809
File: plugins/woocommerce/src/Blocks/BlockTypes/ProductButton.php:222-225
Timestamp: 2025-06-13T17:11:13.732Z
Learning: In plugins/woocommerce/src/Blocks/BlockTypes/ProductButton.php, the team intentionally relies on toggling the disabled CSS class (via data-wp-class--disabled) instead of binding the disabled attribute, to mirror the behavior of the classic WooCommerce template.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: Check Asset Sizes
GitHub Check: build

🔇 Additional comments (1)

plugins/woocommerce/changelog/fix-woopmnt-5218-wc-nox-testing-mode-link-redirects-to-sandbox-page-instead (1)

1-4: Changelog entry looks good.

The entry follows the repo’s changelog convention (Significance + Type + short description).
No further action needed.

github-actions · 2025-07-29T11:55:42Z

Size Change: -5 B (0%)

Total Size: 5.92 MB

_{compressed-size-action}

github-actions · 2025-07-29T12:00:20Z

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

…edirects-to-sandbox-page-instead

…nts documentation

github-actions · 2025-08-05T12:04:57Z

Testing Guidelines

Hi @woocommerce/developer-advocacy,

Apart from reviewing the code changes, please make sure to review the testing instructions (Guide) and verify that relevant tests (E2E, Unit, Integration, etc.) have been added or updated as needed.

Reminder: PR reviewers are required to document testing performed. This includes:

🖼️ Screenshots or screen recordings.
📝 List of functionality tested / steps followed.
🌐 Site details (environment attributes such as hosting type, plugins, theme, store size, store age, and relevant settings).
🔍 Any analysis performed, such as assessing potential impacts on environment attributes and other plugins, conducting performance profiling, or using LLM/AI-based analysis.

⚠️ Within the testing details you provide, please ensure that no sensitive information (such as API keys, passwords, user data, etc.) is included in this public issue.

vladolaru

Thank you for working on this, @mgascam! Pre-approving this, but there is one place that still features the old link: here.

…esources

mgascam · 2025-08-05T14:18:48Z

Thank you for working on this, @mgascam! Pre-approving this, but there is one place that still features the old link: here.

Thanks for the review @vladolaru! I fixed it in this commit and also found another link pointing to the old url docs/contribution/testing/writing-high-quality-testing-instructions.md

…edirects-to-sandbox-page-instead

piinthecloud

Docs changes approved ✅

…edirects-to-sandbox-page-instead

mgascam added 2 commits July 29, 2025 12:58

Amend testing payments documentation link in WooPayments NOX flow

d0fd193

Add changelog

7a87831

github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jul 29, 2025

Merge branch 'trunk' into fix/woopmnt-5218-wc-nox-testing-mode-link-r…

a93c016

…edirects-to-sandbox-page-instead

mgascam marked this pull request as ready for review July 29, 2025 11:52

coderabbitai bot reviewed Jul 29, 2025

View reviewed changes

mordeth assigned mgascam Jul 29, 2025

mgascam added 4 commits August 5, 2025 13:20

Merge branch 'trunk' into fix/woopmnt-5218-wc-nox-testing-mode-link-r…

e988c95

…edirects-to-sandbox-page-instead

Merge branch 'trunk' into fix/woopmnt-5218-wc-nox-testing-mode-link-r…

efa5e0c

…edirects-to-sandbox-page-instead

Update links in WooPayments modals to point to the correct test accou…

5f568e0

…nts documentation

Amend changelog

c8e8a86

mgascam requested a review from a team August 5, 2025 12:04

vladolaru approved these changes Aug 5, 2025

View reviewed changes

Update links in documentation to point to the correct test accounts r…

0f52360

…esources

mgascam requested a review from a team as a code owner August 5, 2025 14:14

github-actions bot added the Documentation Issues and PRs related to improving documentation label Aug 5, 2025

Merge branch 'trunk' into fix/woopmnt-5218-wc-nox-testing-mode-link-r…

dda3bb5

…edirects-to-sandbox-page-instead

piinthecloud approved these changes Aug 6, 2025

View reviewed changes

mgascam added 4 commits August 6, 2025 17:54

Merge branch 'trunk' into fix/woopmnt-5218-wc-nox-testing-mode-link-r…

6cc3a45

…edirects-to-sandbox-page-instead

Merge branch 'trunk' into fix/woopmnt-5218-wc-nox-testing-mode-link-r…

6071392

…edirects-to-sandbox-page-instead

Merge branch 'trunk' into fix/woopmnt-5218-wc-nox-testing-mode-link-r…

2c78224

…edirects-to-sandbox-page-instead

Merge branch 'trunk' into fix/woopmnt-5218-wc-nox-testing-mode-link-r…

644a4b6

…edirects-to-sandbox-page-instead

mgascam merged commit 90c6f92 into trunk Aug 7, 2025
22 checks passed

mgascam deleted the fix/woopmnt-5218-wc-nox-testing-mode-link-redirects-to-sandbox-page-instead branch August 7, 2025 10:48

github-actions bot added this to the 10.2.0 milestone Aug 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Amend testing payments documentation link in WooPayments NOX flow #60088

Amend testing payments documentation link in WooPayments NOX flow #60088

Uh oh!

mgascam commented Jul 29, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jul 29, 2025 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

github-actions bot commented Jul 29, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 29, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Aug 5, 2025 •

edited

Loading

Uh oh!

vladolaru left a comment

Uh oh!

mgascam commented Aug 5, 2025

Uh oh!

piinthecloud left a comment

Uh oh!

Uh oh!

Uh oh!

Amend testing payments documentation link in WooPayments NOX flow #60088

Amend testing payments documentation link in WooPayments NOX flow #60088

Uh oh!

Conversation

mgascam commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Submission Review Guidelines:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Testing that has already taken place:

Changelog entry

Significance

Type

Message

Comment

Uh oh!

coderabbitai bot commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test using WordPress Playground

Uh oh!

github-actions bot commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing Guidelines

Uh oh!

vladolaru left a comment

Choose a reason for hiding this comment

Uh oh!

mgascam commented Aug 5, 2025

Uh oh!

piinthecloud left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mgascam commented Jul 29, 2025 •

edited

Loading

coderabbitai bot commented Jul 29, 2025 •

edited

Loading

github-actions bot commented Jul 29, 2025 •

edited

Loading

github-actions bot commented Jul 29, 2025 •

edited

Loading

github-actions bot commented Aug 5, 2025 •

edited

Loading