Fix an issue when a product is not an object #60215

bor0 · 2025-08-06T07:39:35Z

Our bots reported:

Uncaught exception 'Error' with message 'Call to a member function get_purchase_quantity_step() on false' in /var/www/wp-content/plugins/woocommerce/includes/admin/meta-boxes/views/html-order-item.php:107

Changes proposed in this Pull Request:

Use $product when it really exists, as done in other places in the same file.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Testing that has already taken place:

Changelog entry

Automatically create a changelog entry from the details below.

This Pull Request does not require a changelog entry. (Comment required below)

Changelog Entry Details

Significance

Patch
Minor
Major

Type

Fix - Fixes an existing bug
Add - Adds functionality
Update - Update existing functionality
Dev - Development related task
Tweak - A minor adjustment to the codebase
Performance - Address performance issues
Enhancement - Improvement to existing functionality

Message

Changelog Entry Comment

Comment

github-actions · 2025-08-06T07:39:48Z

Testing Guidelines

Hi @mikejolley ,

Apart from reviewing the code changes, please make sure to review the testing instructions (Guide) and verify that relevant tests (E2E, Unit, Integration, etc.) have been added or updated as needed.

Reminder: PR reviewers are required to document testing performed. This includes:

🖼️ Screenshots or screen recordings.
📝 List of functionality tested / steps followed.
🌐 Site details (environment attributes such as hosting type, plugins, theme, store size, store age, and relevant settings).
🔍 Any analysis performed, such as assessing potential impacts on environment attributes and other plugins, conducting performance profiling, or using LLM/AI-based analysis.

⚠️ Within the testing details you provide, please ensure that no sensitive information (such as API keys, passwords, user data, etc.) is included in this public issue.

coderabbitai · 2025-08-06T07:41:40Z

📝 Walkthrough

Walkthrough

A changelog entry was added for the WooCommerce plugin to document a patch-level fix addressing an issue where a product variable was not recognized as an object in the HTML order item context. The related PHP template was updated to ensure safe method calls on the product variable, preventing potential errors.

Changes

Cohort / File(s)	Change Summary
Changelog Entry `plugins/woocommerce/changelog/fix-product-not-an-object`	Added a patch-level changelog entry describing the fix for product object recognition.
WooCommerce Order Item Template `plugins/woocommerce/includes/admin/meta-boxes/views/html-order-item.php`	Modified variable assignment to safely check if `$product` exists before calling a method on it.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b26f997 and 2c71506.

📒 Files selected for processing (1)

plugins/woocommerce/includes/admin/meta-boxes/views/html-order-item.php (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

plugins/woocommerce/includes/admin/meta-boxes/views/html-order-item.php

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (23)

GitHub Check: Blocks e2e tests 8/10 - @woocommerce/plugin-woocommerce [e2e]
GitHub Check: Blocks e2e tests 9/10 - @woocommerce/plugin-woocommerce [e2e]
GitHub Check: Blocks e2e tests 6/10 - @woocommerce/plugin-woocommerce [e2e]
GitHub Check: Blocks e2e tests 7/10 - @woocommerce/plugin-woocommerce [e2e]
GitHub Check: Blocks e2e tests 10/10 - @woocommerce/plugin-woocommerce [e2e]
GitHub Check: Blocks e2e tests 2/10 - @woocommerce/plugin-woocommerce [e2e]
GitHub Check: Blocks e2e tests 5/10 - @woocommerce/plugin-woocommerce [e2e]
GitHub Check: Blocks e2e tests 4/10 - @woocommerce/plugin-woocommerce [e2e]
GitHub Check: Core e2e tests 2/6 - @woocommerce/plugin-woocommerce [e2e]
GitHub Check: Blocks e2e tests 3/10 - @woocommerce/plugin-woocommerce [e2e]
GitHub Check: Core e2e tests 5/6 - @woocommerce/plugin-woocommerce [e2e]
GitHub Check: Metrics - @woocommerce/plugin-woocommerce [performance]
GitHub Check: Core API tests - @woocommerce/plugin-woocommerce [api]
GitHub Check: Blocks e2e tests 1/10 - @woocommerce/plugin-woocommerce [e2e]
GitHub Check: Core e2e tests 6/6 - @woocommerce/plugin-woocommerce [e2e]
GitHub Check: Core e2e tests 4/6 - @woocommerce/plugin-woocommerce [e2e]
GitHub Check: Core e2e tests 3/6 - @woocommerce/plugin-woocommerce [e2e]
GitHub Check: PHP: 7.4 WP: latest - 1 [WP 6.7.3] 2/2 - @woocommerce/plugin-woocommerce [unit:php]
GitHub Check: PHP: 8.4 WP: latest [WP latest] 2/2 - @woocommerce/plugin-woocommerce [unit:php]
GitHub Check: PHP: 7.4 WP: latest - 1 [WP 6.7.3] 1/2 - @woocommerce/plugin-woocommerce [unit:php]
GitHub Check: PHP: 8.4 WP: latest [WP latest] 1/2 - @woocommerce/plugin-woocommerce [unit:php]
GitHub Check: Core e2e tests 1/6 - @woocommerce/plugin-woocommerce [e2e]
GitHub Check: build

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/product-not-an-object

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-08-06T07:46:41Z

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

plugins/woocommerce/includes/admin/meta-boxes/views/html-order-item.php

…-item.php Co-authored-by: Akeda Bagus <akeda.bagus@automattic.com>

gedex · 2025-08-07T12:25:54Z

To reproduce:

Create an order that has a product item.
From wp_woocommerce_order_itemmeta table, lookup for the created order above. Set _product_id to an invalid product (i.e. 0)
Visit edit-order screen

* Fix an issue when a product is not an object * Update plugins/woocommerce/includes/admin/meta-boxes/views/html-order-item.php Co-authored-by: Akeda Bagus <akeda.bagus@automattic.com> --------- Co-authored-by: Akeda Bagus <akeda.bagus@automattic.com>

github-actions · 2025-08-07T12:38:50Z

IMPORTANT: Merging this PR to the appropriate branches is critical to the release process and ensures that the bug does not cause regressions in the future releases.

Cherry picking was successful for release/10.1. Please merge the following PR: [Backport to release/10.1] Fix an issue when a product is not an object

…ct (#60252) Fix an issue when a product is not an object (#60215) * Fix an issue when a product is not an object * Update plugins/woocommerce/includes/admin/meta-boxes/views/html-order-item.php --------- Co-authored-by: Boro Sitnikovski <buritomath@gmail.com> Co-authored-by: Akeda Bagus <akeda.bagus@automattic.com>

Fix an issue when a product is not an object

b26f997

bor0 requested a review from mikejolley August 6, 2025 07:39

github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Aug 6, 2025

gedex reviewed Aug 7, 2025

View reviewed changes

plugins/woocommerce/includes/admin/meta-boxes/views/html-order-item.php Outdated Show resolved Hide resolved

Update plugins/woocommerce/includes/admin/meta-boxes/views/html-order…

2c71506

…-item.php Co-authored-by: Akeda Bagus <akeda.bagus@automattic.com>

gedex approved these changes Aug 7, 2025

View reviewed changes

bor0 added this to the 10.1.0 milestone Aug 7, 2025

bor0 merged commit e25d125 into trunk Aug 7, 2025
44 checks passed

bor0 deleted the fix/product-not-an-object branch August 7, 2025 12:37

github-actions bot mentioned this pull request Aug 7, 2025

[Backport to release/10.1] Fix an issue when a product is not an object #60252

Merged

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix an issue when a product is not an object #60215

Fix an issue when a product is not an object #60215

Uh oh!

bor0 commented Aug 6, 2025

Uh oh!

github-actions bot commented Aug 6, 2025

Uh oh!

coderabbitai bot commented Aug 6, 2025 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

github-actions bot commented Aug 6, 2025 •

edited

Loading

Uh oh!

Uh oh!

gedex commented Aug 7, 2025 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Aug 7, 2025

Uh oh!

Uh oh!

Fix an issue when a product is not an object #60215

Fix an issue when a product is not an object #60215

Uh oh!

Conversation

bor0 commented Aug 6, 2025

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Testing that has already taken place:

Changelog entry

Significance

Type

Message

Comment

Uh oh!

github-actions bot commented Aug 6, 2025

Testing Guidelines

Uh oh!

coderabbitai bot commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

github-actions bot commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test using WordPress Playground

Uh oh!

Uh oh!

gedex commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Aug 7, 2025

Uh oh!

Uh oh!

coderabbitai bot commented Aug 6, 2025 •

edited

Loading

github-actions bot commented Aug 6, 2025 •

edited

Loading

gedex commented Aug 7, 2025 •

edited

Loading