Skip to content

Skip test_json_search_customers for now #60216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 6, 2025
Merged

Skip test_json_search_customers for now #60216

merged 2 commits into from
Aug 6, 2025

Conversation

naman03malhotra
Copy link
Contributor

@naman03malhotra naman03malhotra commented Aug 6, 2025 •
edited
Loading

Submission Review Guidelines:

Changes proposed in this Pull Request:

test_json_search_customers keeps failing intermittently, skipping it for now, to have a proper investigation later.

Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Changelog Entry Comment

Comment Doesn't need changelog.

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Aug 6, 2025
@naman03malhotra naman03malhotra changed the title Skip test_json_search_customers for now Skip test_json_search_customers for now Aug 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

Testing Guidelines

Hi @roccotripaldi ,

Apart from reviewing the code changes, please make sure to review the testing instructions (Guide) and verify that relevant tests (E2E, Unit, Integration, etc.) have been added or updated as needed.

Reminder: PR reviewers are required to document testing performed. This includes:

  • 🖼️ Screenshots or screen recordings.
  • 📝 List of functionality tested / steps followed.
  • 🌐 Site details (environment attributes such as hosting type, plugins, theme, store size, store age, and relevant settings).
  • 🔍 Any analysis performed, such as assessing potential impacts on environment attributes and other plugins, conducting performance profiling, or using LLM/AI-based analysis.

⚠️ Within the testing details you provide, please ensure that no sensitive information (such as API keys, passwords, user data, etc.) is included in this public issue.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 6, 2025 •
edited
Loading

📝 Walkthrough

Walkthrough

A single test method, test_json_search_customers, in the WooCommerce test suite was updated to skip execution by adding a call to $this->markTestSkipped() with an explanatory message. No other logic or assertions in the test were changed.

Changes

Cohort / File(s) Change Summary
Skip Flaky Test
plugins/woocommerce/tests/php/includes/class-wc-ajax-test.php		 The test_json_search_customers method now calls $this->markTestSkipped() to temporarily skip the test due to intermittent failures.
Changelog Entry
plugins/woocommerce/changelog/skip-test_json_search_customers		 Added a changelog entry documenting the temporary skip of the test_json_search_customers test.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4a7ac44 and 863a03c.

📒 Files selected for processing (1)
  • plugins/woocommerce/changelog/skip-test_json_search_customers (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • plugins/woocommerce/changelog/skip-test_json_search_customers
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: PHP: 7.4 WP: latest - 1 [WP 6.7.3] 1/2 - @woocommerce/plugin-woocommerce [unit:php]
  • GitHub Check: PHP: 8.4 WP: latest [WP latest] 2/2 - @woocommerce/plugin-woocommerce [unit:php]
  • GitHub Check: PHP: 7.4 WP: latest - 1 [WP 6.7.3] 2/2 - @woocommerce/plugin-woocommerce [unit:php]
  • GitHub Check: PHP: 8.4 WP: latest [WP latest] 1/2 - @woocommerce/plugin-woocommerce [unit:php]
  • GitHub Check: Lint - @woocommerce/plugin-woocommerce
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch skip/test_json_search_customers

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@naman03malhotra
Copy link
Contributor Author

@roccotripaldi change log is not required for the PR.

roccotripaldi
roccotripaldi approved these changes Aug 6, 2025
View reviewed changes
Copy link
Contributor

@roccotripaldi roccotripaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roccotripaldi change log is not required for the PR.

Got it, thanks Naman. Should we create an issue to track the investigation?

@naman03malhotra naman03malhotra force-pushed the skip/test_json_search_customers branch from db2c1eb to 863a03c Compare August 6, 2025 11:34
@naman03malhotra
Copy link
Contributor Author

@roccotripaldi I've reopened the exisiting one here: #60010

@naman03malhotra naman03malhotra enabled auto-merge (squash) August 6, 2025 11:42
@naman03malhotra naman03malhotra merged commit 59c0d49 into trunk Aug 6, 2025
15 checks passed
@naman03malhotra naman03malhotra deleted the skip/test_json_search_customers branch August 6, 2025 11:43
@github-actions github-actions bot added this to the 10.2.0 milestone Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roccotripaldi roccotripaldi roccotripaldi approved these changes

Assignees
No one assigned
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Milestone
10.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@naman03malhotra @roccotripaldi