Skip to content

[Migrator]: Add ImportSession from DataLiberation #60237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: migrator/shopify-woo-mapper
Choose a base branch
from
Open

[Migrator]: Add ImportSession from DataLiberation #60237

wants to merge 3 commits into from

Conversation

naman03malhotra
Copy link
Contributor

@naman03malhotra naman03malhotra commented Aug 6, 2025 •
edited
Loading

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes #59823

This PR moves the ImportSession lib from DataLiberation lib to Woo Core. We are moving the lib as is, with slight modification with using the usual exception class. Check p1753341910238079-slack-C08RLHX87MM discussion for more context.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Make sure the CI is passing.

Testing that has already taken place:

Changelog entry

  • Automatically create a changelog entry from the details below.
  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Changelog Entry Comment

Comment

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Aug 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

Testing Guidelines

Hi @roccotripaldi ,

Apart from reviewing the code changes, please make sure to review the testing instructions (Guide) and verify that relevant tests (E2E, Unit, Integration, etc.) have been added or updated as needed.

Reminder: PR reviewers are required to document testing performed. This includes:

  • 🖼️ Screenshots or screen recordings.
  • 📝 List of functionality tested / steps followed.
  • 🌐 Site details (environment attributes such as hosting type, plugins, theme, store size, store age, and relevant settings).
  • 🔍 Any analysis performed, such as assessing potential impacts on environment attributes and other plugins, conducting performance profiling, or using LLM/AI-based analysis.

⚠️ Within the testing details you provide, please ensure that no sensitive information (such as API keys, passwords, user data, etc.) is included in this public issue.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025 •
edited
Loading

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

roccotripaldi
roccotripaldi approved these changes Aug 6, 2025
View reviewed changes
Copy link
Contributor

@roccotripaldi roccotripaldi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed docblock here. I saw a potential typo. Feel free to commit it if I got it right!

This looks like a straight forward copy of wp core class. CI tests pass. It's not being loaded any where, so I didn't bother with smoke tests.

@naman03malhotra @roccotripaldi
Update plugins/woocommerce/src/Internal/CLI/Migrator/Lib/ImportSessio…
6f0fc77 
…n.php

Co-authored-by: Rocco Tripaldi <tripaldir@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roccotripaldi roccotripaldi roccotripaldi approved these changes

Assignees
No one assigned
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naman03malhotra @roccotripaldi