-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Update sidebar labels and positioning in release docs #60243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Testing GuidelinesHi @prettyboymp @woocommerce/developer-advocacy @woocommerce/flux, Apart from reviewing the code changes, please make sure to review the testing instructions (Guide) and verify that relevant tests (E2E, Unit, Integration, etc.) have been added or updated as needed. Reminder: PR reviewers are required to document testing performed. This includes:
|
📝 WalkthroughWalkthroughThis change updates the front matter metadata in several release-related documentation files by adding or modifying Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: .coderabbit.yml 📒 Files selected for processing (7)
🧰 Additional context used🧠 Learnings (10)📓 Common learnings
📚 Learning: in woocommerce core repository, changelog entries for all prs live in `plugins/woocommerce/changelog...
Applied to files:
📚 Learning: woocommerce uses wordpress versioning conventions where minor versions in x.y.z format are constrain...
Applied to files:
📚 Learning: action scheduler is bundled into woocommerce and always available, so there's no need to add fallbac...
Applied to files:
📚 Learning: woocommerce is currently in the midst of an admin redesign project, so temporary/short-term css solu...
Applied to files:
📚 Learning: in woocommerce blocks, when porting existing code patterns that have known issues (like parseint tru...
Applied to files:
📚 Learning: woocommerce uses autoprefixer in their postcss configuration (plugins/woocommerce/client/blocks/post...
Applied to files:
📚 Learning: in woocommerce blocks css, prefer using standard css properties like `scrollbar-width` over vendor-s...
Applied to files:
📚 Learning: woocommerce legacy javascript files in plugins/woocommerce/client/legacy/js/ must use older javascri...
Applied to files:
📚 Learning: woocommerce trunk versions follow the pattern `x.y.0-dev` where the patch version is always `0`. thi...
Applied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (7)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
@joshuatf, the changes look good. I noticed the sections in the sidebar have different titles than the ones in the Release overview section ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than @albarin's feedback, everything looks good.
Changes proposed in this Pull Request:
Updates the sidebar labels so there aren't duplicates and reorders them so that they match the release docs index page order.
Screenshots or screen recordings:
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
docs/_docu-tools
npm i && npm start
Contribution -> Releases
Testing that has already taken place:
Changelog entry
Changelog Entry Details
Significance
Type
Message
Changelog Entry Comment
Comment