Skip to content

Fix admin_init/init executed in reverse order and wrong user logged in #6011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix admin_init/init executed in reverse order and wrong user logged in #6011

wants to merge 1 commit into from

Conversation

kkmuffme
Copy link

Fix #6010

@kkmuffme kkmuffme requested a review from a team as a code owner October 22, 2024 22:43
@schlessera
Copy link
Member

Looks good, we just need to resolve the PHPCS issues.

swissspidy
swissspidy reviewed Nov 1, 2024
View reviewed changes
@swissspidy swissspidy requested a review from schlessera November 1, 2024 08:38
@kkmuffme
Copy link
Author

@schlessera PHPCS issues are resolved, please merge

@kkmuffme kkmuffme force-pushed the fix-context-admin-hook-order-and-wrong-user-6010 branch from 130c54f to e40d1b5 Compare January 17, 2025 15:10
@schlessera schlessera force-pushed the fix-context-admin-hook-order-and-wrong-user-6010 branch from e40d1b5 to 44e9925 Compare May 6, 2025 07:39
@codecov Codecov
Copy link

codecov bot commented May 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
php/WP_CLI/Context/Admin.php 81.25% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy left review comments

@schlessera schlessera Awaiting requested review from schlessera

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug scope:framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

context=admin executes admin_init before anything on init is executed potentially causing fatal errors
3 participants
@kkmuffme @schlessera @swissspidy