Skip to content

Conversation

azure-sdk
Copy link
Collaborator

https://github.com/Azure/sdk-release-request/issues/6545
Recording test fail, detailed info is in pipeline log(search keyword FAILED)!!!
https://dev.azure.com/azure-sdk/internal/_build?definitionId=842
BuildTargetingString
azure-mgmt-storagecache
Skip.CreateApiReview

@azure-sdk
Copy link
Collaborator Author

@Copilot Copilot AI review requested due to automatic review settings September 4, 2025 01:13
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This is an auto-release PR that migrates the azure-mgmt-storagecache package from setup.py to pyproject.toml configuration format, updating the API version from 2024-03-01 to 2025-07-01 and modernizing the codebase structure.

  • Removes legacy setup.py and sdk_packaging.toml files in favor of pyproject.toml
  • Updates API version throughout the codebase from 2024-03-01 to 2025-07-01
  • Modernizes code generation with improved type hints, error handling, and imports

Reviewed Changes

Copilot reviewed 142 out of 142 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
setup.py Removed legacy setuptools configuration file
sdk_packaging.toml Removed in favor of pyproject.toml configuration
pyproject.toml Added modern Python packaging configuration with project metadata
generated_tests/*.py Updated test files with new API version and pylint suppressions
generated_samples/*.py Updated sample files with API version changes and import cleanups
azure/mgmt/storagecache/operations/*.py Updated operations files with modernized imports, type hints, and API version

Comment on lines +75 to +86
[packaging]
package_name = "azure-mgmt-storagecache"
package_nspkg = "azure-mgmt-nspkg"
package_pprint_name = "Storage Cache Management"
package_doc_id = ""
is_stable = true
is_arm = true
title = "StorageCacheManagementClient"
need_msrestazure = false
need_azuremgmtcore = true
sample_link = ""
exclude_folders = ""
Copy link
Preview

Copilot AI Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The [packaging] section appears to be legacy configuration that may not be compatible with pyproject.toml standard. This section should be reviewed to ensure it's necessary or properly formatted for the new packaging system.

Suggested change
[packaging]
package_name = "azure-mgmt-storagecache"
package_nspkg = "azure-mgmt-nspkg"
package_pprint_name = "Storage Cache Management"
package_doc_id = ""
is_stable = true
is_arm = true
title = "StorageCacheManagementClient"
need_msrestazure = false
need_azuremgmtcore = true
sample_link = ""
exclude_folders = ""

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant