Add telemetry success field #42846
Open
Add telemetry success field #42846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into add-telemetry-success-field
There was a problem hiding this comment.
Pull Request Overview
This PR adds telemetry success tracking for dropped items in the Azure Monitor OpenTelemetry exporter, implementing a new telemetry_success field as specified in the Telemetry Collection Spec. The implementation extracts success flags from RequestData and RemoteDependencyData envelopes and includes them in dropped item metrics.
Key Changes
- Enhanced dropped item tracking to include telemetry success status for REQUEST and DEPENDENCY types
- Updated data structures to support nested success tracking in counters
- Added comprehensive test coverage for both successful and failed telemetry scenarios
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
_utils.py |
Added helper function to extract success flags from telemetry envelopes and updated tracking calls |
_customer_sdkstats.py |
Modified data structures and methods to support telemetry success tracking with nested dictionaries |
test_base_customer_sdkstats.py |
Added new test cases for CLIENT_EXCEPTION scenarios with both success and failure cases |
test_customer_sdkstats.py |
Enhanced existing integration test to verify telemetry success categorization |
...-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/statsbeat/_customer_sdkstats.py
Show resolved
Hide resolved
sdk/monitor/azure-monitor-opentelemetry-exporter/tests/statsbeat/test_customer_sdkstats.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
telemetry_successfield to dropped items as per spec - https://github.com/aep-health-and-standards/Telemetry-Collection-Spec/pull/606All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines