V5 pipelines #7889
Open
V5 pipelines #7889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors error handling, telemetry, and cache interface code to centralize default messages, standardize constant usage, and enhance telemetry correlation.
- Replaced inline error message maps with a shared getDefaultErrorMessage helper.
- Updated many modules to import from a unified Constants module and swapped to the new PerformanceEvents exports.
- Changed ICacheManager remove methods to require a correlationId and return void, and updated implementations accordingly.
Reviewed Changes
Copilot reviewed 205 out of 428 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/error/ClientAuthError.ts | Removed hardcoded ClientAuthErrorMessages and simplified constructor to use default messages. |
| src/error/AuthError.ts & CacheError.ts | Introduced getDefaultErrorMessage, removed inline message maps, and adjusted super() calls. |
| src/cache/interface/ICacheManager.ts & CacheManager.ts | Changed removeAccount/removeAccessToken/etc. signatures to take a correlationId and return void. |
Comments suppressed due to low confidence (4)
lib/msal-common/src/error/ClientAuthErrorCodes.ts:21
- The literal uses mixed casing (
appMetadata) in the snake_case string. For consistency with other codes, consider"multiple_matching_app_metadata".
export const multipleMatchingAppMetadata = "multiple_matching_appMetadata";
lib/msal-common/src/error/ClientAuthError.ts:19
- By passing only
additionalMessagehere, the original descriptive message forerrorCodeis lost whenever additionalMessage is provided. Consider fetching the default description and concatenating, e.g.:const baseMsg = getDefaultErrorMessage(errorCode); super(errorCode, additionalMessage ?${baseMsg}: ${additionalMessage}: baseMsg);
super(errorCode, additionalMessage);
lib/msal-common/src/error/CacheError.ts:26
- The thrown error message no longer includes the
errorCodeprefix, breaking consistency with other errors. Consider usingsuper(${errorCode}: ${message});so the code remains part of the message.
super(message);
lib/msal-common/src/cache/interface/ICacheManager.ts:200
- The signature change to require a
correlationIdbreaks existing callers ofremoveAllAccounts()with no arguments. Either update all call sites to pass the correlationId or consider overloading/retaining a zero-arg version for backward compatibility.
removeAllAccounts(correlationId: string): void;
tnorling
approved these changes
Jul 1, 2025
|
Reminder: This PR appears to be stale. If this PR is still a work in progress please mark as draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.