Skip to content

Set ImageRenderMethodForWeb.HttpGet, as a default imageRenderMethodForWeb for flutter 3.27.0 compatibility workaround #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Set ImageRenderMethodForWeb.HttpGet, as a default imageRenderMethodForWeb for flutter 3.27.0 compatibility workaround #996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49af7dd
Set `ImageRenderMethodForWeb.HttpGet,
rednikisfun Dec 12, 2024
f48dfb3
CachedNetworkImageProvider change default to `ImageRenderMethodForWeb…
rednikisfun Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cached_network_image/example/macos/Flutter/GeneratedPluginRegistrant.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import FlutterMacOS
import Foundation

import path_provider_foundation
import sqflite
import sqflite_darwin
import url_launcher_macos

func RegisterGeneratedPlugins(registry: FlutterPluginRegistry) {
Expand Down
2 changes: 1 addition & 1 deletion cached_network_image/lib/src/cached_image_widget.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ class CachedNetworkImage extends StatelessWidget {
this.maxHeightDiskCache,
this.errorListener,
ImageRenderMethodForWeb imageRenderMethodForWeb =
ImageRenderMethodForWeb.HtmlImage,
ImageRenderMethodForWeb.HttpGet,
double scale = 1.0,
}) : _image = CachedNetworkImageProvider(
imageUrl,
Expand Down
6 changes: 3 additions & 3 deletions cached_network_image/lib/src/image_provider/cached_network_image_provider.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@ import 'dart:async' show Future, StreamController;
import 'dart:ui' as ui show Codec;

import 'package:cached_network_image/src/image_provider/multi_image_stream_completer.dart';
import 'package:cached_network_image_platform_interface/cached_network_image_platform_interface.dart'
show ErrorListener, ImageRenderMethodForWeb;
import 'package:cached_network_image_platform_interface/cached_network_image_platform_interface.dart'
if (dart.library.io) '_image_loader.dart'
if (dart.library.js_interop) 'package:cached_network_image_web/cached_network_image_web.dart'
show ImageLoader;
import 'package:cached_network_image_platform_interface/cached_network_image_platform_interface.dart'
show ErrorListener, ImageRenderMethodForWeb;
import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
import 'package:flutter_cache_manager/flutter_cache_manager.dart';
Expand All @@ -28,7 +28,7 @@ class CachedNetworkImageProvider
this.headers,
this.cacheManager,
this.cacheKey,
this.imageRenderMethodForWeb = ImageRenderMethodForWeb.HtmlImage,
this.imageRenderMethodForWeb = ImageRenderMethodForWeb.HttpGet,
});

/// CacheManager from which the image files are loaded.
Expand Down
4 changes: 2 additions & 2 deletions cached_network_image/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ version: 3.4.1

environment:
sdk: ^3.0.0
flutter: '>=3.10.0'
flutter: ">=3.10.0"

dependencies:
cached_network_image_platform_interface: ^4.1.1
Expand All @@ -21,7 +21,7 @@ dependencies:
octo_image: ^2.1.0

dev_dependencies:
file: '>=7.0.0 <8.0.0'
file: ">=7.0.0 <8.0.0"
flutter_lints: ^4.0.0
flutter_test:
sdk: flutter
Expand Down
4 changes: 2 additions & 2 deletions cached_network_image_platform_interface/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@ homepage: https://github.com/Baseflow/flutter_cached_network_image

environment:
sdk: ^3.0.0
flutter: '>=3.10.0'
flutter: ">=3.10.0"

dependencies:
flutter:
sdk: flutter
flutter_cache_manager: ^3.4.1

dev_dependencies:
file: '>=7.0.0 <8.0.0'
file: ">=7.0.0 <8.0.0"
flutter_lints: ^4.0.0
flutter_test:
sdk: flutter
4 changes: 2 additions & 2 deletions cached_network_image_web/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ homepage: https://github.com/Baseflow/flutter_cached_network_image

environment:
sdk: ^3.0.0
flutter: '>=3.10.0'
flutter: ">=3.10.0"

dependencies:
cached_network_image_platform_interface: ^4.1.1
Expand All @@ -15,7 +15,7 @@ dependencies:
web: ^1.0.0

dev_dependencies:
file: '>=7.0.0 <8.0.0'
file: ">=7.0.0 <8.0.0"
flutter_lints: ^4.0.0
flutter_test:
sdk: flutter