Skip to content

Update InnerBrowser.php #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update InnerBrowser.php #59

wants to merge 1 commit into from

Conversation

CJDennis
Copy link

Allow all options to be deselected by passing through an empty array

@CJDennis
Update InnerBrowser.php
09b21a6 
Allow all options to be deselected by passing through an empty array
@Naktibalda
Copy link
Member

Please add test for this change similar to

lib-innerbrowser/tests/unit/Codeception/Module/TestsForWeb.php

Lines 374 to 382 in 00947b1

public function testSelectMultipleOptionsByText()
{
$this->module->amOnPage('/form/select_multiple');
$this->module->selectOption('What do you like the most?', array('Play Video Games', 'Have Sex'));
$this->module->click('Submit');
$form = data::get('form');
$this->assertSame(array('play', 'adult'), $form['like']);
}

and rebase this branch on master, I fixed broken test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CJDennis @Naktibalda