Skip to content

Make each PostgresCluster..volumes.additional atomic #4241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2025
Merged

Make each PostgresCluster..volumes.additional atomic #4241

merged 1 commit into from
Aug 13, 2025
+57 −35

Conversation

cbandy
Copy link
Member

@cbandy cbandy commented Aug 13, 2025 •
edited
Loading

This limits each volume to a single manager and allows us to express that container names are a unique set.

I intended to touch only validation and documentation for it, but I edited the field language as well. I'm less certain about my word-smithing there, so happy to drop or change those:

--- explain.main.txt	2025-08-13 13:50:07.000000000 -0500
+++ explain.branch.txt	2025-08-13 13:50:28.000000000 -0500
@@ -10,19 +10,19 @@
     
 FIELDS:
   claimName	<string> -required-
-    A reference to a preexisting PVC.
+    Name of an existing PersistentVolumeClaim.
 
   containers	<[]string>
-    The containers to attach this volume to.
-    An omitted `Containers` field matches all containers.
-    An empty `Containers` field matches no containers.
+    The names of containers in which to mount this volume.
+    The default mounts the volume in *all* containers. An empty list does not
+    mount the volume.
 
   name	<string> -required-
-    The name of the volume used for mounting path.
-    Volumes are mounted in the pods at `volumes/<NAME>`
-    Must be unique.
+    The name of the directory in which to mount this volume.
+    Volumes are mounted in containers at `/volumes/{name}`.
 
   readOnly	<boolean>
-    Sets the write/read mode of the volume
+    When true, mount the volume read-only, otherwise read-write. Defaults to
+    false.

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

make check check-envtest check-chainsaw passes, but I didn't try any KUTTL tests.

Type of Changes:

  • Documentation
  • Other

@cbandy cbandy requested a review from benjaminjb August 13, 2025 19:40
@cbandy @benjaminjb
Make each PostgresCluster..volumes.additional atomic
3cba537 
This limits each volume to a single manager and allows us to express
that container names are a unique set.

Co-authored-by: Ben Blattberg <ben.blattberg@crunchydata.com>
@cbandy cbandy force-pushed the container-name-validation branch from 2d432cb to 3cba537 Compare August 13, 2025 20:25
@cbandy cbandy enabled auto-merge (rebase) August 13, 2025 20:25
@cbandy cbandy merged commit 6b01868 into CrunchyData:main Aug 13, 2025
16 checks passed
@cbandy cbandy deleted the container-name-validation branch August 13, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminjb benjaminjb benjaminjb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbandy @benjaminjb