Skip to content

Conversation

iadjivon
Copy link
Contributor

@iadjivon iadjivon commented Aug 14, 2025

What does this PR do? What is the motivation?

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:

Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.

Additional notes

@iadjivon iadjivon requested review from a team as code owners August 14, 2025 19:40
@iadjivon iadjivon added the WORK IN PROGRESS No review needed, it's a wip ;) label Aug 14, 2025
@github-actions github-actions bot added the Images Images are added/removed with this PR label Aug 14, 2025
Copy link
Contributor

github-actions bot commented Aug 14, 2025

✅ Documentation Team Review

The documentation team has approved this pull request. Thank you for your contribution!

@iadjivon iadjivon requested a review from a team as a code owner August 15, 2025 21:53
@iadjivon iadjivon force-pushed the ida.adjivon/DOCS-11593-gcp branch from 7a1043b to 1a2d2ef Compare August 15, 2025 22:08
@iadjivon iadjivon removed the request for review from a team August 15, 2025 22:36
@iadjivon iadjivon removed the WORK IN PROGRESS No review needed, it's a wip ;) label Aug 18, 2025
@brett0000FF brett0000FF added the editorial review Waiting on a more in-depth review label Aug 18, 2025
Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a small, non blocking comment to consider in future updates.


<div class="alert alert-info">To instrument your Google Cloud Run applications with an in-process approach, see <a href="/serverless/google_cloud_run/containers/in_process">Instrument Google Cloud Run In-Process</a>.</div>

<div class="alert alert-info">
<strong>Have you set up your <a href="/integrations/google-cloud-platform/">Google Cloud integration</a>?</strong> Datadog recommends setting up the integration, which collects metrics and logs from Google Cloud services, before proceeding on to instrumentation. Remember to add the <code>cloud asset viewer</code> role to your service account and enable the Cloud Asset Inventory API in Google Cloud.
</div>

## Setup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the "Containers" h3 was removed, I think we should remove "Application". Also, it'd probably be nice to put a quick intro sentence between Setup and the tabs (or call out that this is setup for applications. (Just an idea for a follow up--not blocking)

@brett0000FF
Copy link
Contributor

@brett0000FF brett0000FF merged commit a55b078 into master Aug 20, 2025
23 of 25 checks passed
@brett0000FF brett0000FF deleted the ida.adjivon/DOCS-11593-gcp branch August 20, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial review Waiting on a more in-depth review Images Images are added/removed with this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants