feat(engine-server): disable wire adapters in SSR (salesforce#1948)

pmdartus · web-flow · commit cd793940fa3b · 2020-06-29T14:22:05.000+02:00
diff --git a/packages/@lwc/engine-core/src/framework/vm.ts b/packages/@lwc/engine-core/src/framework/vm.ts
@@ -296,7 +296,7 @@ export function createVM<HostNode, HostElement>(
     createComponent(vm, def.ctor);
 
     // Initializing the wire decorator per instance only when really needed
-    if (hasWireAdapters(vm)) {
+    if (isFalse(renderer.ssr) && hasWireAdapters(vm)) {
         installWireAdapters(vm);
     }
 
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/expected.html b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/expected.html
@@ -0,0 +1 @@
+<x-wire><template shadow-root>Wire adapter invoked: false</template></x-wire>
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/modules/x/wire/adapter.js b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/modules/x/wire/adapter.js
@@ -0,0 +1,5 @@
+export let isAdapterInvoked = false;
+
+export function adapter() {
+    isAdapterInvoked = true;
+}
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/modules/x/wire/wire.html b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/modules/x/wire/wire.html
@@ -0,0 +1,3 @@
+<template>
+    Wire adapter invoked: {isAdapterInvoked}
+</template>
diff --git a/packages/@lwc/engine-server/src/__tests__/fixtures/wire/modules/x/wire/wire.js b/packages/@lwc/engine-server/src/__tests__/fixtures/wire/modules/x/wire/wire.js
@@ -0,0 +1,12 @@
+import { LightningElement, wire } from 'lwc';
+
+import { adapter, isAdapterInvoked } from './adapter';
+
+export default class Wire extends LightningElement {
+    @wire(adapter)
+    wiredProp;
+
+    get isAdapterInvoked() {
+        return isAdapterInvoked;
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -296,7 +296,7 @@ export function createVM<HostNode, HostElement>(`
`296`	`296`	`createComponent(vm, def.ctor);`
`297`	`297`
`298`	`298`	`// Initializing the wire decorator per instance only when really needed`
`299`		`- if (hasWireAdapters(vm)) {`
	`299`	`+ if (isFalse(renderer.ssr) && hasWireAdapters(vm)) {`
`300`	`300`	`installWireAdapters(vm);`
`301`	`301`	`}`
`302`	`302`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+<x-wire><template shadow-root>Wire adapter invoked: false</template></x-wire>`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+<template>`
	`2`	`+ Wire adapter invoked: {isAdapterInvoked}`
	`3`	`+</template>`