Skip to content

feat(engine-server): Disable wire adapters in SSR #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2020
Merged

feat(engine-server): Disable wire adapters in SSR #1948

merged 1 commit into from
Jun 29, 2020

Conversation

pmdartus
Copy link
Member

Details

This PR disables wire adapter execution when running in SSR mode.

Does this PR introduce breaking changes?

  • ✅ No, it does not introduce breaking changes.

The PR fulfills these requirements:

  • Have tests for the proposed changes been added? ✅
  • Have you followed these instructions to clearly describe the issue being fixed or feature enhanced? ✅

GUS work item

W-7532187

@salesforce-best-lwc-internal

This comment has been minimized.

Sign in to view
@salesforce-best-lwc-internal

This comment has been minimized.

Sign in to view
@salesforce-best-lwc-internal
Copy link

🥳 Performance Improvement

Best has detected that there is a 7.6% performance improvement across your benchmarks.

Please click here to see more details.

Click to view significantly changed benchmarks

lwc-engine-benchmark

✅ Improvements base (c5f5581) target (69a9b7a) trend
table-append-1k.benchmark/benchmark-table/append/1k 273.25 (± 2.39ms) 244.81 (± 2.14ms) -28.4ms (10.4%)
table-clear-1k.benchmark/benchmark-table/clear/1k 16.40 (± 0.17ms) 13.94 (± 0.17ms) -2.5ms (15.0%)
table-create-10k.benchmark/benchmark-table/create/10k 1436.00 (± 9.25ms) 1275.72 (± 7.16ms) -160.3ms (11.2%)
table-create-1k.benchmark/benchmark-table/create/1k 171.25 (± 1.20ms) 146.43 (± 1.39ms) -24.8ms (14.5%)
table-update-10th-1k.benchmark/benchmark-table/update-10th/1k 145.57 (± 1.77ms) 132.31 (± 1.40ms) -13.3ms (9.1%)
tablecmp-append-1k.benchmark/benchmark-table-component/append/1k 375.24 (± 2.14ms) 347.26 (± 2.14ms) -28.0ms (7.5%)
tablecmp-clear-1k.benchmark/benchmark-table-component/clear/1k 9.39 (± 0.17ms) 6.65 (± 0.16ms) -2.7ms (29.1%)
tablecmp-create-10k.benchmark/benchmark-table-component/create/10k 2071.40 (± 13.24ms) 1873.57 (± 17.22ms) -197.8ms (9.6%)
tablecmp-create-1k.benchmark/benchmark-table-component/create/1k 242.85 (± 1.76ms) 214.94 (± 1.09ms) -27.9ms (11.5%)
tablecmp-update-10th-1k.benchmark/benchmark-table-component/update-10th/1k 125.28 (± 0.76ms) 113.75 (± 0.96ms) -11.5ms (9.2%)
wc-append-1k.benchmark/benchmark-table-wc/append/1k 527.74 (± 12.79ms) 495.15 (± 7.47ms) -32.6ms (6.2%)
wc-clear-1k.benchmark/benchmark-table-wc/clear/1k 26.30 (± 0.24ms) 21.45 (± 0.23ms) -4.9ms (18.4%)
wc-create-10k.benchmark/benchmark-table-wc/create/10k 3426.99 (± 6.25ms) 3248.65 (± 12.79ms) -178.3ms (5.2%)
wc-create-1k.benchmark/benchmark-table-wc/create/1k 381.05 (± 2.75ms) 348.17 (± 2.58ms) -32.9ms (8.6%)
wc-update-10th-1k.benchmark/benchmark-table-wc/update-10th/1k 128.16 (± 1.06ms) 111.72 (± 0.81ms) -16.4ms (12.8%)

@pmdartus pmdartus merged commit cd79394 into master Jun 29, 2020
@pmdartus pmdartus deleted the pmdartus/disable-wire-adapters branch June 29, 2020 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekashida ekashida ekashida approved these changes

@ravijayaramappa ravijayaramappa Awaiting requested review from ravijayaramappa

+1 more reviewer

@jodarove jodarove jodarove approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmdartus @ekashida @jodarove