update for suggestion (npm#288)

makhmudjon-inadullaev · Makhmudjon Inadullaev · web-flow · commit a1265c8877ca · 2022-10-27T19:23:38.000+05:00
Co-authored-by: Makhmudjon Inadullaev &lt;makhmudjon@MakhmudjonsMBP2.home&gt;
diff --git a/src/theme/nav.yml b/src/theme/nav.yml
@@ -287,7 +287,6 @@
   variants:
     - title: Version 6.14.17 (Legacy Release)
       shortName: v6
-      tabIndex: 1
       url: /cli/v6
       default: false
       children:
@@ -527,7 +526,6 @@
               description: Cleaning the slate
     - title: Version 7.24.2 (Legacy Release)
       shortName: v7
-      tabIndex: 2
       url: /cli/v7
       default: false
       children:
@@ -783,7 +781,6 @@
     - title: Version 8.19.2 (Latest Release)
       shortName: v8
       url: /cli/v8
-      tabIndex: 3
       default: true
       children:
         - title: CLI Commands
@@ -1050,7 +1047,6 @@
     - title: Version 9.0.1 (Current Release)
       shortName: v9
       url: /cli/v9
-      tabIndex: 4
       default: false
       children:
         - title: CLI Commands
diff --git a/theme/src/components/variant-select.js b/theme/src/components/variant-select.js
@@ -47,8 +47,11 @@ function VariantSelect(props) {
             window.location.href = match.page.url;
         }
       }
-
-      items.push(<Dropdown.Item aria-label={`${match.variant.title}. List items ${index + 1} of ${variantPages.length}`} onKeyDown={onItemEnterKey} onBlur={index === (variantPages.length - 1) ? collapseDropdown : undefined} tabIndex={0} onClick={() => { window.location.href = match.page.url; }} key={match.variant.title}>{match.variant.title}</Dropdown.Item>);
+      items.push(
+        <a style={{ textDecoration: 'none' }} aria-label={`${match.variant.title}. List items ${index + 1} of ${variantPages.length}`} href={match.page.url} onKeyDown={onItemEnterKey} onBlur={index === (variantPages.length - 1) ? collapseDropdown : undefined} tabIndex={0} key={match.variant.title}>
+          <Dropdown.Item>{match.variant.title}</Dropdown.Item>
+        </a>
+      );
   });
 
   return (

Original file line number	Diff line number	Diff line change
`@@ -47,8 +47,11 @@ function VariantSelect(props) {`
`47`	`47`	`window.location.href = match.page.url;`
`48`	`48`	`}`
`49`	`49`	`}`
`50`		`-`
`51`		- items.push(<Dropdown.Item aria-label={`${match.variant.title}. List items ${index + 1} of ${variantPages.length}`} onKeyDown={onItemEnterKey} onBlur={index === (variantPages.length - 1) ? collapseDropdown : undefined} tabIndex={0} onClick={() => { window.location.href = match.page.url; }} key={match.variant.title}>{match.variant.title}</Dropdown.Item>);
	`50`	`+ items.push(`
	`51`	+ <a style={{ textDecoration: 'none' }} aria-label={`${match.variant.title}. List items ${index + 1} of ${variantPages.length}`} href={match.page.url} onKeyDown={onItemEnterKey} onBlur={index === (variantPages.length - 1) ? collapseDropdown : undefined} tabIndex={0} key={match.variant.title}>
	`52`	`+ <Dropdown.Item>{match.variant.title}</Dropdown.Item>`
	`53`	`+ </a>`
	`54`	`+ );`
`52`	`55`	`});`
`53`	`56`
`54`	`57`	`return (`