chore: upgrade java8 to java21 for analytics folder #10148

nitesh-55 · 2025-08-15T18:59:37Z

Description

Checklist

gemini-code-assist

Summary of Changes

Hello @nitesh-55, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new App Engine sample for Google Analytics, specifically configured to run on Java 21. It provides a complete setup for tracking events using Google Analytics within an App Engine application, including necessary configuration files and a servlet for event tracking.

Highlights

New App Engine Java 21 Sample: Introduces a new Google Analytics sample application under appengine-java21/analytics, demonstrating App Engine integration with Java 21.
Google Analytics Event Tracking: The sample includes AnalyticsServlet.java which sends event data to Google Analytics using the Measurement Protocol.
Maven Project Setup: A pom.xml is provided, configuring the project for Java 21 compilation, App Engine SDK 2.0.23, and relevant dependencies like httpclient and jstl.
App Engine Deployment Configuration: appengine-web.xml is configured to use the java21 runtime and defines an environment variable for the Google Analytics tracking ID.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request upgrades the analytics sample to Java 21. The changes are a good start, but there are a few critical and high-severity issues that need to be addressed. The pom.xml is still configured for Java 1.8, which needs to be updated to 21. Additionally, there are some security concerns, such as using HTTP instead of HTTPS for API calls. I've left specific comments with suggestions for improvement.

gemini-code-assist · 2025-08-15T19:01:04Z

appengine-java21/analytics/pom.xml

+    <maven.compiler.target>1.8</maven.compiler.target>
+    <maven.compiler.source>1.8</maven.compiler.source>


The maven.compiler.target and maven.compiler.source are set to 1.8. Since this is an upgrade to Java 21, these should be updated to 21.

<maven.compiler.target>21</maven.compiler.target> <maven.compiler.source>21</maven.compiler.source>

This is actually correct because this sample is using

gemini-code-assist · 2025-08-15T19:01:04Z

appengine-java21/analytics/src/main/java/com/example/appengine/analytics/AnalyticsServlet.java

+    String trackingId = System.getenv("GA_TRACKING_ID");
+    URIBuilder builder = new URIBuilder();
+    builder
+        .setScheme("http")


For security best practices, you should use https instead of http when communicating with the Google Analytics API.

Suggested change

.setScheme("http")

.setScheme("https")

gemini-code-assist · 2025-08-15T19:01:05Z

appengine-java21/analytics/src/main/java/com/example/appengine/analytics/AnalyticsServlet.java

+        .addParameter("tid", trackingId) // Tracking ID / Property ID.
+        // Anonymous Client Identifier. Ideally, this should be a UUID that
+        // is associated with particular user, device, or browser instance.
+        .addParameter("cid", "555")


The comment on the preceding lines suggests that the client ID (cid) should ideally be a UUID. Hardcoding it to "555" is not ideal for a sample. Consider generating a random UUID to better demonstrate the intended usage.

Suggested change

.addParameter("cid", "555")

.addParameter("cid", java.util.UUID.randomUUID().toString())

appengine-java21/analytics/README.md

gemini-code-assist · 2025-08-15T19:01:05Z

appengine-java21/analytics/src/main/webapp/WEB-INF/appengine-web.xml

+    <runtime>java21</runtime>
+   <app-engine-apis>true</app-engine-apis>
+  <system-properties>
+    <property name="appengine.use.EE8" value="true"/>
+     </system-properties>
+   <env-variables>
+    <env-var name="GA_TRACKING_ID" value="YOUR-GA-TRACKING-ID" />
+  </env-variables>


The XML indentation in this file is inconsistent, which makes it harder to read. Please format it with consistent indentation (e.g., 2 spaces per level).

<runtime>java21</runtime> <app-engine-apis>true</app-engine-apis> <system-properties> <property name="appengine.use.EE8" value="true"/> </system-properties> <env-variables> <env-var name="GA_TRACKING_ID" value="YOUR-GA-TRACKING-ID" /> </env-variables>

@nitesh-55 I know this was as is existing in the file, can you address this one so it's consistent?

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

iennae · 2025-08-15T19:22:29Z

appengine-java21/analytics/pom.xml

@@ -0,0 +1,136 @@
+<!--
+ Copyright 2017 Google LLC.


@nitesh-55 no . after LLC.

For others reading this, this is migrating an existing sample over to java 21 and so the year 2017 is correct.

iennae · 2025-08-15T19:23:34Z

appengine-java21/analytics/src/main/java/com/example/appengine/analytics/AnalyticsServlet.java

+
+package com.example.appengine.analytics;
+
+// [START analytics_track]


@nitesh-55 please fix the region tag here. Since this is already a migration, you don't have to keep the invalid region tag. you can create updated as this file isn't in use. Talk to Fran about how to construct a valid more helpful one here please.

updated the region tag

I'm not seeing the update. It should start with gae_

iennae · 2025-08-15T19:27:45Z

appengine-java21/analytics/src/main/webapp/WEB-INF/appengine-web.xml

+-->
+<!-- [END_EXCLUDE] -->
+<appengine-web-app xmlns="http://appengine.google.com/ns/1.0">
+    <runtime>java21</runtime>


this file looks to have the correct syntax that Ludo provided as guidance for the migration.

iennae · 2025-08-15T19:29:19Z

appengine-java21/analytics/pom.xml

+  <packaging>war</packaging>
+  <version>1.0-SNAPSHOT</version>
+  <groupId>com.example.appengine</groupId>
+  <artifactId>appengine-analytics-j21</artifactId>


this is one of the areas that ludo gave guidance of needing to change and looks correct.

…s-samples into j21-upgrade-analytics

iennae · 2025-08-20T20:42:34Z

appengine-java8/analytics/src/main/java/com/example/appengine/analytics/AnalyticsServlet.java

@@ -16,7 +16,7 @@

 package com.example.appengine.analytics;

-// [START analytics_track]
+// [START analytics_track_j21]


I see what you did, you updated the existing java8 file. Don't do this, update the java21 version above and remove this change from your commit. also a valid region tag would start with gae in this case.

sorry,my bad. Updated region tag name

…s-samples into j21-upgrade-analytics

iennae · 2025-08-21T19:40:59Z

as discussed, let's add a subdirectory of ee8 under the runtime version.

chore: upgrade java8 to java21 for analytics folder

1091dfc

product-auto-label bot added the samples Issues that are directly related to samples. label Aug 15, 2025

gemini-code-assist bot reviewed Aug 15, 2025

View reviewed changes

fix: Update appengine-java21/analytics/README.md

3494d3a

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

iennae reviewed Aug 15, 2025

View reviewed changes

nitesh-55 added 2 commits August 19, 2025 23:31

Updated region tag,fixed alignment in appengine-web.xml

151aa12

Merge branch 'j21-upgrade-analytics' of github.com:nitesh-55/java-doc…

ad974d2

…s-samples into j21-upgrade-analytics

iennae reviewed Aug 20, 2025

View reviewed changes

nitesh-55 added 2 commits August 21, 2025 19:09

Merge branch 'j21-upgrade-analytics' of github.com:nitesh-55/java-doc…

cf65fce

…s-samples into j21-upgrade-analytics

Updated name of region tag

3ca0e8b

		<maven.compiler.target>1.8</maven.compiler.target>
		<maven.compiler.source>1.8</maven.compiler.source>

	.addParameter("cid", "555")
	.addParameter("cid", java.util.UUID.randomUUID().toString())


		package com.example.appengine.analytics;

		// [START analytics_track]

chore: upgrade java8 to java21 for analytics folder #10148

Are you sure you want to change the base?

chore: upgrade java8 to java21 for analytics folder #10148

Uh oh!

Conversation

nitesh-55 commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gemini-code-assist bot Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iennae commented Aug 21, 2025

Uh oh!

Uh oh!

nitesh-55 commented Aug 15, 2025 •

edited

Loading