fix(ci): update default django static bucket name #13536
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @glasnt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've updated the default bucket name used for Django static assets within the CI/CD testing setup. This change aims to improve the identification of assets in testing projects by providing a more specific bucket name.
Highlights
- CI/CD Configuration Update: The _STORAGE_BUCKET variable in run/django/e2e_test_setup.yaml has been modified to use a more descriptive name, changing from "${PROJECT_ID}-bucket-${_VERSION}" to "django-static-${PROJECT_ID}-${_VERSION}". This helps in better identifying static assets during testing.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the default storage bucket name in the end-to-end test setup for Django, making it more descriptive. While this change is good for identification, it introduces a critical issue. The corresponding cleanup configuration in run/django/e2e_test_cleanup.yaml has not been updated with the new bucket name format. This will cause the cleanup step to fail, leading to orphaned storage buckets and resource leaks after the tests run. This must be fixed to ensure the test environment is properly torn down.
Updates the default bucket name for testing, to help identify assets in testing projects b/418598361
Updates the default bucket name for testing, to help identify assets in testing projects b/418598361
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)