fix(genai): change parameters for imagen capability model #13541
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @katiemn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request modifies the input parameters for samples utilizing the Imagen capability model. The core change involves removing the seed=1 parameter from the EditImageConfig instantiation within various image generation example scripts. This adjustment aims to enhance the flexibility and variability of the generated images by no longer fixing the random seed, which previously ensured reproducible outputs.
Highlights
- Parameter Modification: The hardcoded
seed=1parameter has been removed from theEditImageConfigconstructor calls across all affected files. - Affected Samples: This change impacts several Imagen image generation samples, including those for Canny edge, raw reference, scribble, style reference, and subject reference, allowing for potentially more varied or non-deterministic outputs.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request removes the fixed seed parameter from EditImageConfig across five image generation samples, making their output non-deterministic. While this is a reasonable change for samples, it removes the ability for users to easily reproduce results. I've suggested adding a commented-out seed parameter in each of the modified files. This would keep the default behavior non-deterministic while providing a simple way for users to enable reproducibility for documentation or debugging purposes.
Description
Modify input parameters for samples that use the Imagen capability model.