Skip to content

Conversation

idleberg
Copy link
Contributor

@idleberg idleberg commented Aug 31, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. new formula PR adds a new formula to Homebrew/homebrew-core labels Aug 31, 2025
class Txikijs < Formula
desc "Small and powerful JavaScript runtime"
homepage "https://github.com/saghul/txiki.js"
url "https://github.com/saghul/txiki.js.git",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This project builds its own copies of dependencies provided by Homebrew. This makes it unsuitable for Homebrew/core, unfortunately. See https://docs.brew.sh/Acceptable-Formulae.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It means the deps folder has its own dependencies not by homebrew.

Copy link
Contributor Author

@idleberg idleberg Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This project builds its own copies of dependencies provided by Homebrew.

@carlocab Is this about the submodules? Then I'll continue making changes and try to get it to work. Otherwise, this can be closed.

@daeho-ro daeho-ro marked this pull request as draft September 2, 2025 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosquash Automatically squash pull request commits according to Homebrew style. new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants