Skip to content

Conversation

fabriciofx
Copy link

@fabriciofx fabriciofx commented Aug 31, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Name: hping3
Version: 3.0.0
URL: https://github.com/fabriciofx/hping
sha256: e6f92c64bb3bed5397b7e0303686231c9192143436e4bfb0e30fd8a3f68fd612

@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Aug 31, 2025
@chenrui333 chenrui333 added the notability Project is not notable enough for inclusion label Aug 31, 2025
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Aug 31, 2025
@fabriciofx fabriciofx changed the title hping3 3.0.0-alpha-1 hping3 3.0.0 Aug 31, 2025
@fabriciofx fabriciofx force-pushed the hping3 branch 2 times, most recently from 0e3aae8 to 4934e86 Compare August 31, 2025 18:44
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Aug 31, 2025
@fabriciofx fabriciofx force-pushed the hping3 branch 10 times, most recently from 9074ef4 to b1afbf3 Compare September 1, 2025 00:39
Copy link
Member

@daeho-ro daeho-ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this can be added, it was removed from homebrew for the maintenance problem. Still there is a origin repo and you are one of forks, so naming also should care.

Comment on lines +13 to +23
on_macos do
depends_on "libpcap" => :build
end

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already depends on by uses_from_macos "libpcap"

Suggested change
on_macos do
depends_on "libpcap" => :build
end

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daeho-ro I've already changed this and uses_from_macos "libpcap" works in some macOS versions and not in others. I'm trying to solve it.

Comment on lines +23 to +34

resource "tcl" do
url "https://downloads.sourceforge.net/project/tcl/Tcl/9.0.2/tcl9.0.2-src.tar.gz"
sha256 "e074c6a8d9ba2cddf914ba97b6677a552d7a52a3ca102924389a05ccb249b520"
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This too, depends_on "tcl-tk"

Suggested change
resource "tcl" do
url "https://downloads.sourceforge.net/project/tcl/Tcl/9.0.2/tcl9.0.2-src.tar.gz"
sha256 "e074c6a8d9ba2cddf914ba97b6677a552d7a52a3ca102924389a05ccb249b520"
end

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daeho-ro I've put depends_on "tcl-tk" but it didn't worked for Linux, only for macOS. That's why I'm compiling from source only in Linux.

@fabriciofx
Copy link
Author

fabriciofx commented Sep 1, 2025

Not sure this can be added, it was removed from homebrew for the maintenance problem. Still there is a origin repo and you are one of forks, so naming also should care.

@daeho-ro Are you sure? Because I've searched for 'hping' and haven't found any formula.

And yes, there is a lot of maintenance problem in the original source, but I (think) solved them.

@fabriciofx
Copy link
Author

fabriciofx commented Sep 1, 2025

@daeho-ro I've got a problem: I think hping3 is abandoned. There hasn't been any update since 2014 (almost 11 years!), but I'd like to create a Homebrew package for a "modified" version (I only removed some compilation warnings and added support for autotools). However, there's a complication: the audit check. I can't use my fork as the "official" source (well, I don't know how). Could you help me?

@stefanb stefanb changed the title hping3 3.0.0 hping3 3.0.0 (new formula) Sep 1, 2025
@fxcoudert
Copy link
Member

If the software is unmaintained, at some point a fork will become either "official", or at least "most widely used", i.e., there will be activity from more than one person.

Right now, this is your own fork of hping, but not community-maintained or official or "widely used" in any way. This is alright, but it just means we can't really chose it for Homebrew. You can, however, maintain this in a private tap: https://docs.brew.sh/How-to-Create-and-Maintain-a-Tap

@fxcoudert fxcoudert closed this Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new formula PR adds a new formula to Homebrew/homebrew-core notability Project is not notable enough for inclusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants