-
-
Notifications
You must be signed in to change notification settings - Fork 13k
hping3 3.0.0 (new formula) #235689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hping3 3.0.0 (new formula) #235689
Conversation
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
0e3aae8
to
4934e86
Compare
9074ef4
to
b1afbf3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this can be added, it was removed from homebrew for the maintenance problem. Still there is a origin repo and you are one of forks, so naming also should care.
on_macos do | ||
depends_on "libpcap" => :build | ||
end | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already depends on by uses_from_macos "libpcap"
on_macos do | |
depends_on "libpcap" => :build | |
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daeho-ro I've already changed this and uses_from_macos "libpcap"
works in some macOS versions and not in others. I'm trying to solve it.
|
||
resource "tcl" do | ||
url "https://downloads.sourceforge.net/project/tcl/Tcl/9.0.2/tcl9.0.2-src.tar.gz" | ||
sha256 "e074c6a8d9ba2cddf914ba97b6677a552d7a52a3ca102924389a05ccb249b520" | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This too, depends_on "tcl-tk"
resource "tcl" do | |
url "https://downloads.sourceforge.net/project/tcl/Tcl/9.0.2/tcl9.0.2-src.tar.gz" | |
sha256 "e074c6a8d9ba2cddf914ba97b6677a552d7a52a3ca102924389a05ccb249b520" | |
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daeho-ro I've put depends_on "tcl-tk"
but it didn't worked for Linux, only for macOS. That's why I'm compiling from source only in Linux.
@daeho-ro Are you sure? Because I've searched for 'hping' and haven't found any formula. And yes, there is a lot of maintenance problem in the original source, but I (think) solved them. |
@daeho-ro I've got a problem: I think hping3 is abandoned. There hasn't been any update since 2014 (almost 11 years!), but I'd like to create a Homebrew package for a "modified" version (I only removed some compilation warnings and added support for autotools). However, there's a complication: the audit check. I can't use my fork as the "official" source (well, I don't know how). Could you help me? |
If the software is unmaintained, at some point a fork will become either "official", or at least "most widely used", i.e., there will be activity from more than one person. Right now, this is your own fork of hping, but not community-maintained or official or "widely used" in any way. This is alright, but it just means we can't really chose it for Homebrew. You can, however, maintain this in a private tap: https://docs.brew.sh/How-to-Create-and-Maintain-a-Tap |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?Name: hping3
Version: 3.0.0
URL: https://github.com/fabriciofx/hping
sha256: e6f92c64bb3bed5397b7e0303686231c9192143436e4bfb0e30fd8a3f68fd612