Fix microsoft#98137

sandy081 · sandy081 · commit 02b367b75704 · 2020-05-21T01:59:04.000+02:00
diff --git a/src/vs/workbench/services/configuration/common/jsonEditingService.ts b/src/vs/workbench/services/configuration/common/jsonEditingService.ts
@@ -110,11 +110,13 @@ export class JSONEditingService implements IJSONEditingService {
 		const model = reference.object.textEditorModel;
 
 		if (this.hasParseErrors(model)) {
+			reference.dispose();
 			return this.reject<IReference<IResolvedTextEditorModel>>(JSONEditingErrorCode.ERROR_INVALID_FILE);
 		}
 
 		// Target cannot be dirty if not writing into buffer
 		if (checkDirty && this.textFileService.isDirty(resource)) {
+			reference.dispose();
 			return this.reject<IReference<IResolvedTextEditorModel>>(JSONEditingErrorCode.ERROR_FILE_DIRTY);
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -110,11 +110,13 @@ export class JSONEditingService implements IJSONEditingService {`
`110`	`110`	`const model = reference.object.textEditorModel;`
`111`	`111`
`112`	`112`	`if (this.hasParseErrors(model)) {`
	`113`	`+ reference.dispose();`
`113`	`114`	`return this.reject<IReference<IResolvedTextEditorModel>>(JSONEditingErrorCode.ERROR_INVALID_FILE);`
`114`	`115`	`}`
`115`	`116`
`116`	`117`	`// Target cannot be dirty if not writing into buffer`
`117`	`118`	`if (checkDirty && this.textFileService.isDirty(resource)) {`
	`119`	`+ reference.dispose();`
`118`	`120`	`return this.reject<IReference<IResolvedTextEditorModel>>(JSONEditingErrorCode.ERROR_FILE_DIRTY);`
`119`	`121`	`}`
`120`	`122`