fix microsoft#98136

sandy081 · sandy081 · commit fbb367917ce2 · 2020-05-21T02:02:01.000+02:00
diff --git a/src/vs/workbench/services/keybinding/common/keybindingEditing.ts b/src/vs/workbench/services/keybinding/common/keybindingEditing.ts
@@ -230,10 +230,12 @@ export class KeybindingsEditingService extends Disposable implements IKeybinding
 				if (model.getValue()) {
 					const parsed = this.parse(model);
 					if (parsed.parseErrors.length) {
+						reference.dispose();
 						return Promise.reject<any>(new Error(localize('parseErrors', "Unable to write to the keybindings configuration file. Please open it to correct errors/warnings in the file and try again.")));
 					}
 					if (parsed.result) {
 						if (!isArray(parsed.result)) {
+							reference.dispose();
 							return Promise.reject<any>(new Error(localize('errorInvalidConfiguration', "Unable to write to the keybindings configuration file. It has an object which is not of type Array. Please open the file to clean up and try again.")));
 						}
 					} else {

Original file line number	Diff line number	Diff line change
`@@ -230,10 +230,12 @@ export class KeybindingsEditingService extends Disposable implements IKeybinding`
`230`	`230`	`if (model.getValue()) {`
`231`	`231`	`const parsed = this.parse(model);`
`232`	`232`	`if (parsed.parseErrors.length) {`
	`233`	`+ reference.dispose();`
`233`	`234`	`return Promise.reject<any>(new Error(localize('parseErrors', "Unable to write to the keybindings configuration file. Please open it to correct errors/warnings in the file and try again.")));`
`234`	`235`	`}`
`235`	`236`	`if (parsed.result) {`
`236`	`237`	`if (!isArray(parsed.result)) {`
	`238`	`+ reference.dispose();`
`237`	`239`	`return Promise.reject<any>(new Error(localize('errorInvalidConfiguration', "Unable to write to the keybindings configuration file. It has an object which is not of type Array. Please open the file to clean up and try again.")));`
`238`	`240`	`}`
`239`	`241`	`} else {`