Use trust_x_header and test it (fix #195) #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we actually remove the parameter? 🤔 Do you think this makes sense @jhnstrk ? |
Yes I think so, and also remove the |
|
Let's drop it then 🙏 |
Removes the trust_x_headers option for create_form_parser and associated tests.
1e12a71 to
d6476c2
Compare
|
I rebased on the current master and removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the boolean.
Note that this changes the default behavior but makes it consistent with what the function documentation was declaring.
If we want to maintain behaviour, we may want to expose this in option in
parse_form.