Fix flaky shared flow subscription #4489
Conversation
|
The change makes sense, thanks! However, the failing tests are important. This changes the behavior of other operators non-trivially, and we need to evaluate how big the change is. Could you please classify the tests into those that fail reasonably and those that should ideally still pass? Then, we'll figure out if we need to isolate the change to just |
| fun testBaseline() = | ||
| checkBuffer(-1) { this } |
There was a problem hiding this comment.
Unrelated: Idea gives a warning on this: Flow is constructed but not used. That's a false positive, right? I'll report it if so.
| import kotlinx.coroutines.* | ||
| import kotlinx.coroutines.channels.* | ||
| import kotlinx.coroutines.testing.* |
There was a problem hiding this comment.
Unrelated: L1: Do we need the suppression on Line 1? I don't quite understand how it is relevant here.
…ed-flow-subscription-impl
|
I aimed to fix all tests but these (conflicting with #4493)
|
#4488