Skip to content

support #rrggbbaa instead of #aarrggbb #8517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
farfromrefug opened this issue Apr 10, 2020 · 2 comments
Closed

support #rrggbbaa instead of #aarrggbb #8517

farfromrefug opened this issue Apr 10, 2020 · 2 comments
Labels
breaking-change enhancement in progress ns-next

Comments

@farfromrefug
Copy link
Collaborator

in the web the standard is #rrggbbaa but {N} supports #aarrggbb
Right now i am facing an issue with webpack which is wrongly translated colors in production
NativeScript/nativescript-dev-webpack#1133

It also have bad side effects like in VSCode which wrongly shows those colors.

Now i know it is a breaking change for user. So what i am thinking about is a flag in the app package.json to use the new format.

Would you agree with that? (i could make a simple PR)
@NathanaelA

This comment was marked as abuse.

Sign in to view
@farfromrefug farfromrefug mentioned this issue Apr 11, 2020
Closed
@farfromrefug
Copy link
Collaborator Author

@NathanaelA here is the PR #8519

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change enhancement in progress ns-next
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@farfromrefug @NathanaelA @NickIliev