fix(android): setInterval impl to match c++ and prevent drift #10787
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
The current setInterval function uses a problematic timing calculation that causes drift and incorrect behavior when callbacks take time to execute.
Root Cause: The current implementation tries to align intervals to wall-clock time using:
This causes:
Extra callbacks in test_setInterval_callbackNotDelayedByBusyWork because the timing calculation doesn't account for callback execution time properly
Missed callbacks in test_setInterval_callbackSkippedByBusyWork because the busy work throws off the timing alignment
What is the new behavior?
The implementation follows the same pattern as the native C++ implementation in the android runtime, which updates the start time after each execution to prevent drift.